All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] libsepol: add include/sepol/cil symlink for in-tree builds
Date: Fri, 28 Aug 2026 17:58:39 +0000	[thread overview]
Message-ID: <20260828175840.04E4B1F00ADF@smtp.kernel.org> (raw)
In-Reply-To: <20260828175314.38256-1-stephen.smalley.work@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Invalid repository target. The patch is intended for the SELinux userspace repository (which contains `libsepol`, `secilc`, `libsemanage`) but was mistakenly applied to the Linux kernel tree.
--

commit 38dcb6e7783a077514cbc09a9dbfdbd6ef4f7c1a
Author: Stephen Smalley <stephen.smalley.work@gmail.com>

libsepol: add include/sepol/cil symlink for in-tree builds

This patch adds an include/sepol/cil symlink to allow in-tree builds of
SELinux userspace tools to resolve <sepol/cil/cil.h> without a DESTDIR
install.

> diff --git a/libsepol/include/sepol/cil b/libsepol/include/sepol/cil
> new file mode 120000
> index 0000000000000..a1b89f5916832
> --- /dev/null
> +++ b/libsepol/include/sepol/cil
> @@ -0,0 +1 @@
> +../../cil/include/cil

[Severity: High]
Is this patch intended for the selinux userspace repository?

Applying this patch creates a dangling symlink at the root of the kernel
tree, because the target ../../cil/include/cil does not exist in the Linux
kernel source. It appears this might have been mistakenly applied to the
kernel tree instead of the userspace repository containing libsepol,
secilc, and libsemanage.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828175314.38256-1-stephen.smalley.work@gmail.com?part=1

  reply	other threads:[~2026-08-28 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 17:53 [PATCH] libsepol: add include/sepol/cil symlink for in-tree builds Stephen Smalley
2026-08-28 17:58 ` sashiko-bot [this message]
2026-08-28 20:13 ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828175840.04E4B1F00ADF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.