From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xu Yunxiang <xyx2021@mail.ustc.edu.cn>
Cc: Willy Tarreau <w@1wt.eu>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
security@kernel.org, andrii@kernel.org, memxor@gmail.com,
eddyz87@gmail.com, Tao Lyu <tao.lyu@epfl.ch>,
stable@vger.kernel.org
Subject: Re: [PATCH 6.6.y] bpf: Ensure reg is PTR_TO_STACK in process_iter_arg
Date: Fri, 28 Aug 2026 07:23:30 +0200 [thread overview]
Message-ID: <2026082824-donation-nail-1190@gregkh> (raw)
In-Reply-To: <apEShxAOrNDGUoga@DESKTOP-F439VFF.localdomain>
On Fri, Aug 28, 2026 at 12:45:59PM +0800, Xu Yunxiang wrote:
> Currently KF_ARG_PTR_TO_ITER handling does not check reg->type.
> process_iter_arg() therefore accepts any register whose constant offset
> resolves to the stack slot of an initialized iterator — a bare SCALAR
> (kernel panic) as well as pointers to real kernel objects (map value,
> ctx).
>
> This is the 6.6.y equivalent of 12659d28615d ("bpf: Ensure reg is
> PTR_TO_STACK in process_iter_arg"), which is in mainline since 6.13-rc
> and was backported to 6.12.5. The original commit was framed as
> completeness (align with process_dynptr_func) and was never queued for
> 6.6.y. 6.6 still lacks the type check (verified through 6.6.154).
>
> The verbose argument index uses `regno` to match the surrounding 6.6
> messages in this function (later trees print regno - 1).
> The verifier_bits_iter.c hunk from 12659d28615d is omitted: that file
> does not exist in 6.6.
>
> commit 12659d28615d upstream
> Fixes: 06accc8779c1 ("bpf: add support for open-coded iterator loops")
> Cc: stable@vger.kernel.org # 6.6.y
>
> Signed-off-by: Xu Yunxiang <xyx2021@mail.ustc.edu.cn>
You lost all of the original authorship and signed-off-by lines, AND you
changed this from the original in a way and did not document that.
Please fix that up and resend. See the thousands of examples on the
stable@vger.kernel.org list for examples of how to do this.
thanks,
greg k-h
next prev parent reply other threads:[~2026-08-28 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <apDzg_JciKsoBk_A@1wt.eu>
2026-08-28 4:45 ` [PATCH 6.6.y] bpf: Ensure reg is PTR_TO_STACK in process_iter_arg Xu Yunxiang
2026-08-28 5:23 ` Greg Kroah-Hartman [this message]
2026-08-29 3:27 ` [PATCH 6.6.y v2] " Xu Yunxiang
2026-08-30 2:56 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026082824-donation-nail-1190@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=memxor@gmail.com \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tao.lyu@epfl.ch \
--cc=w@1wt.eu \
--cc=xyx2021@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.