Re: [PATCH] media: dt-bindings: ak7375: Add AK7377

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing driver match for newly added compatible string 'asahi-kasei,ak7377'.
--

commit 9537c3ff68990acd9e078305609fb067fe093ae9
Author: Jan-Michael Brummer <jan.brummer@tabos.org>

media: dt-bindings: ak7375: Add AK7377

This commit updates the device tree binding for the AK7375 to include the
AK7377, which is register compatible and driven by the same driver.

> diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> index fe312cc6a8731..c040757eb80c9 100644
> --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> @@ -18,6 +18,7 @@ properties:
>      enum:
>        - asahi-kasei,ak7345
>        - asahi-kasei,ak7375
> +      - asahi-kasei,ak7377

[Severity: Medium]
Should the driver match table in drivers/media/i2c/ak7375.c also be updated
to include this new compatible string?

Currently, ak7375_of_table only lists the previous models:

static const struct of_device_id ak7375_of_table[] = {
	{ .compatible = "asahi-kasei,ak7345", .data = &ak7345_cdef, },
	{ .compatible = "asahi-kasei,ak7375", .data = &ak7375_cdef, },
	{ /* sentinel */ }
};

Without adding the new string here, won't a device declaring only
"asahi-kasei,ak7377" fail to probe because the driver lacks a matching
entry?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829052514.18178-2-jan.brummer@tabos.org?part=1