Re: [PATCH v3 1/3] dt-bindings: display: add Chipwealth CH1115 OLED Controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Use of `additionalProperties: false` instead of `unevaluatedProperties: false` restricts inherited properties and forces anti-pattern property re-declaration.
--

commit 1beb1f223427bea55378a246f7b9205ba032f851
Author: Nicolás Antinori <nico.antinori.7@gmail.com>

dt-bindings: display: add Chipwealth CH1115 OLED Controller
    
Chipwealth CH1115 is a controller for monochrome dot matrix OLED panels.

> diff --git a/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml
> new file mode 100644
> index 0000000000000..6b037c40242ec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml

[ ... ]

> +  chipwealth,offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 63
> +    default: 0
> +    description:
> +      Display start line offset. Specifies the vertical alignment and row shift
> +      along the Y-coordinate.
> +
> +  width-mm: true
> +  height-mm: true
> +  flip-horizontal: true
> +  flip-vertical: true
> +  panel-timing: true

[Severity: Medium]
Since this schema includes panel-common.yaml in its allOf block, are these
explicit property re-declarations necessary? They appear redundant with the
inherited schema and can typically be removed when unevaluatedProperties is
used.

> +
> +required:
> +  - compatible
> +  - reg
> +  - width-mm
> +  - height-mm
> +  - panel-timing
> +
> +additionalProperties: false

[Severity: Medium]
Does using additionalProperties: false here improperly restrict the
schema from inheriting standard properties like reset-gpios or
rotation from panel-common.yaml? Should this be unevaluatedProperties: false
instead, so that valid common properties aren't falsely rejected during
board configuration validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787973729.git.nico.antinori.7@gmail.com?part=1