All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: steven@liquorix.net
Cc: oe-kbuild-all@lists.linux.dev
Subject: [zen:7.2/bbr3 1/2] net/ipv4/tcp_bbr3.c:2051:17: warning: variable 'round_delivered' set but not used
Date: Sat, 29 Aug 2026 08:59:56 +0800	[thread overview]
Message-ID: <202608290804.uQTc6zeR-lkp@intel.com> (raw)

tree:   https://github.com/zen-kernel/zen-kernel 7.2/bbr3
head:   f04474ac60538e992f6c6cf854e0fda08632e2da
commit: f7f00444a9ad2284192bfa6aaef7ce9be2d43388 [1/2] tcp/bbr3: add BBRv3 congestion control
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260829/202608290804.uQTc6zeR-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260829/202608290804.uQTc6zeR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608290804.uQTc6zeR-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv4/tcp_bbr3.c: In function 'bbr_main':
>> net/ipv4/tcp_bbr3.c:2051:17: warning: variable 'round_delivered' set but not used [-Wunused-but-set-variable=]
    2051 |         u32 bw, round_delivered;
         |                 ^~~~~~~~~~~~~~~


vim +/round_delivered +2051 net/ipv4/tcp_bbr3.c

  2043	
  2044	__bpf_kfunc static void bbr_main(struct sock *sk, u32 ack, int flag,
  2045					 const struct rate_sample *rs)
  2046	{
  2047		struct tcp_sock *tp = tcp_sk(sk);
  2048		struct bbr *bbr = inet_csk_ca(sk);
  2049		struct bbr_context ctx = { 0 };
  2050		bool update_model = true;
> 2051		u32 bw, round_delivered;
  2052		int ce_ratio = -1;
  2053	
  2054		round_delivered = bbr_update_round_start(sk, rs, &ctx);
  2055		if (bbr->round_start) {
  2056			bbr->rounds_since_probe =
  2057				min_t(s32, bbr->rounds_since_probe + 1, 0xFF);
  2058			ce_ratio = bbr_update_ecn_alpha(sk);
  2059		}
  2060		bbr_plb(sk, rs, ce_ratio);
  2061	
  2062		bbr->ecn_in_round  |= (bbr->ecn_eligible && rs->is_ece);
  2063		bbr_calculate_bw_sample(sk, rs, &ctx);
  2064		bbr_update_latest_delivery_signals(sk, rs, &ctx);
  2065	
  2066		if (bbr_run_fast_path(sk, &update_model, rs, &ctx))
  2067			goto out;
  2068	
  2069		if (update_model)
  2070			bbr_update_model(sk, rs, &ctx);
  2071	
  2072		bbr_update_gains(sk);
  2073		bw = bbr_bw(sk);
  2074		bbr_set_pacing_rate(sk, bw, bbr->pacing_gain);
  2075		bbr_set_cwnd(sk, rs, rs->acked_sacked, bw, bbr->cwnd_gain,
  2076			     tcp_snd_cwnd(tp), &ctx);
  2077		bbr_bound_cwnd_for_inflight_model(sk);
  2078	
  2079	out:
  2080		bbr_advance_latest_delivery_signals(sk, rs, &ctx);
  2081		bbr->prev_ca_state = inet_csk(sk)->icsk_ca_state;
  2082		bbr->loss_in_cycle |= rs->lost > 0;
  2083		bbr->ecn_in_cycle  |= rs->delivered_ce > 0;
  2084	}
  2085	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-29  1:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608290804.uQTc6zeR-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=steven@liquorix.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.