All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jerome Tollet" <jerome.tollet@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [RFC PATCH v2] hwmon: it87: Add basic IT8613E fan monitoring support
Date: Sat, 29 Aug 2026 11:37:20 +0000	[thread overview]
Message-ID: <20260829113720.B6A201F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260829113011.51290-1-jerome.tollet@gmail.com>

> The IT8613E is not recognized by the in-tree it87 driver. Full
> support was proposed previously but withdrawn after problems were found
> in the temperature and PWM paths.
> 
> Add conservative support limited to fan input monitoring. Detect device
> ID 0x8613, check the fan pin muxes, use the existing 16-bit tachometer
> layout, and expose enabled fan inputs read-only. Do not expose voltage,
> temperature, PWM, limit, beep, or alarm interfaces.
> 
> The device ID and fan pin-mux checks follow the earlier v4 proposal by
> Benoit Masson.
> 
> Tested on a system with an IT8613E at 0xa30, revision 12. Only
> fan2_input was exposed, with stable readings between 1268 and 1320 RPM.
> In a back-to-back comparison, the in-tree driver with force_id=0x8622
> reported 1483 RPM and the out-of-tree driver reported 1442 RPM.
> 
> Link: https://lore.kernel.org/linux-hwmon/20260114221210.98071-1-yahoo@perenite.com/
> Signed-off-by: Jerome Tollet <jerome.tollet@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829113011.51290-1-jerome.tollet@gmail.com?part=1


  reply	other threads:[~2026-08-29 11:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 11:30 [RFC PATCH v2] hwmon: it87: Add basic IT8613E fan monitoring support Jerome Tollet
2026-08-29 11:37 ` sashiko-bot [this message]
2026-08-29 15:58 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260829113720.B6A201F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=jerome.tollet@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.