Re: [PATCH v6 2/8] arm64: dts: agilex5: add SD/eMMC host controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro COMBOPHY_RESET is used in the device tree but is not defined anywhere, causing a device tree compilation failure.
--

commit 1fb3de019d554e3e24230c8b530b9bf6aad8b8dd
Author: Tanmay Kathpalia <tanmay.kathpalia@altera.com>

arm64: dts: agilex5: add SD/eMMC host controller

The Agilex5 HPS includes a Cadence SD6HC that drives either an SD card
or eMMC, depending on the SOCDK daughter card. This commit adds the
controller configuration and sets up the SOCDK slot as SD-only.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index b06c6d5d60eed..5ccbd7bf20340 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
[ ... ]
> @@ -300,6 +300,31 @@ portb: gpio-controller@0 {
[ ... ]
> +		emmc: mmc@10808000 {
> +			compatible = "altr,agilex5-sd6hc", "cdns,sd6hc";
> +			reg = <0x10808000 0x1000>;
[ ... ]
> +			resets = <&rst SDMMC_RESET>, <&rst COMBOPHY_RESET>,
> +				 <&rst SDMMC_OCP_RESET>;

[Severity: Low]
Is COMBOPHY_RESET missing a definition in this patch?

When compiling the device trees, this identifier appears to be left unexpanded
by the C preprocessor. This causes a syntax error in the device tree compiler
(dtc) since it expects a valid cell value here.

Should the macro definition be included in this commit or a prerequisite
patch?

> +			reset-names = "sdhc-reset", "combophy", "sdmmc-ocp";
> +
> +			status = "disabled";
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829184252.27644-1-tanmay.kathpalia@altera.com?part=2