Re: [PATCH 1/2] dt-bindings: usb: qcom,snps-dwc3: relax interrupt requirements for ipq4019

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Relaxing the global minimum constraints for 'interrupts' and 'interrupt-names' unintentionally leaves multiple SoCs underconstrained, allowing invalid DT configurations to pass validation.
--

commit 245becf7a38f613732404251842cf1f13abb06d5
Author: Matt Eaton <linux@divinehawk.com>
dt-bindings: usb: qcom,snps-dwc3: relax interrupt requirements for ipq4019

This commit lowers the global minimum interrupt count for qcom,snps-dwc3 to 1
to accommodate qcom,ipq4019-dwc3, adding a dedicated if-then block for it.
It also notes that several other SoCs relied on the top-level minimum and
are subsequently left unconstrained at the low end.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index 7d784a648b7d9..28e78302b814d 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> @@ -137,11 +137,11 @@ properties:
>                                 only on SoCs with non-QUSB2 targets with
>                                 exception of SDM670/SDM845/SM6350.
>          - ss_phy_irq: Used for remote wakeup in Super Speed mode of operation.
> -    minItems: 3
> +    minItems: 1
>      maxItems: 19
>  
>    interrupt-names:
> -    minItems: 3
> +    minItems: 1

[Severity: Medium]
Does lowering the global minimum here unintentionally break validation for
SoCs that relied on the global minimum? For example, device trees defining
qcom,ipq5018-dwc3 or qcom,ipq5332-dwc3 with an incomplete interrupt
specification (like 1 interrupt instead of the required 3 or 4) will no
longer report an error during dtbs_check.

[ ... ]

> @@ -508,6 +508,25 @@ allOf:
>            contains:
>              enum:
>                - qcom,ipq4019-dwc3
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 1
> +          maxItems: 6
> +        interrupt-names:
> +          minItems: 1
> +          items:
> +            - const: dwc_usb3
> +            - const: pwr_event
> +            - const: hs_phy_irq
> +            - const: dp_hs_phy_irq
> +            - const: dm_hs_phy_irq
> +            - const: ss_phy_irq

[Severity: Medium]
The commit message explicitly notes that qcom,ipq9574-dwc3,
qcom,qcm2290-dwc3, qcom,sar2130p-dwc3 and qcom,sm6375-dwc3 are left
unconstrained at the low end by this change. Should new if-then
conditional blocks be added here for these SoCs to properly enforce their
original interrupt minimum counts? Without them, invalid configurations for
these variants will silently pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829-ipq4019-dwc3-migration-v1-0-cc66b54ce21c@divinehawk.com?part=1