From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Frank.Li@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, imx@lists.linux.dev, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: fsl: Replace tabs with spaces
Date: Sat, 29 Aug 2026 19:51:39 +0000 [thread overview]
Message-ID: <20260829195139.BBA1F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260829194203.108240-2-krzysztof.kozlowski@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly states 'YAML files do not use spaces' when it clearly intended to say 'tabs'.
--
commit fc1bb72fd79fb94d419615999bc4d406ae05d524
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
dt-bindings: pinctrl: fsl: Replace tabs with spaces
This commit replaces tabs with spaces in several Freescale pinctrl YAML
bindings to resolve dt-style-check warnings about tab characters not being
allowed in DTS examples.
> dt-bindings: pinctrl: fsl: Replace tabs with spaces
>
> YAML files do not use spaces, even within the values in DTS. No
[Severity: Medium]
The commit message states "YAML files do not use spaces", but given the patch
title and the actual changes replacing tabs with spaces, should this say "YAML
files do not use tabs" instead?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260829194203.108240-2-krzysztof.kozlowski@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-08-29 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 19:42 [PATCH] dt-bindings: pinctrl: fsl: Replace tabs with spaces Krzysztof Kozlowski
2026-08-29 19:51 ` sashiko-bot [this message]
2026-09-14 9:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829195139.BBA1F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.