From: Andrew Morton <akpm@linux-foundation.org>
To: Yuntao Wang <yuntao.wang@linux.dev>
Cc: Jason Baron <jbaron@akamai.com>,
Jim Cromie <jim.cromie@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dyndbg: fix incorrect mod_ct value in dynamic_debug_init()
Date: Sat, 29 Aug 2026 20:23:06 -0700 [thread overview]
Message-ID: <20260829202306.67cf6ff7223b1bc33b57730d@linux-foundation.org> (raw)
In-Reply-To: <20260811121831.577848-2-yuntao.wang@linux.dev>
On Tue, 11 Aug 2026 20:18:30 +0800 Yuntao Wang <yuntao.wang@linux.dev> wrote:
> Suppose all `struct _ddebug` instances belong to the same module, mod_ct
> should be 1, but it is currently 0.
Oh. Why. Does
if (strcmp(modname, iter->modname)) {
not evaluate to true in this situation?
ie, more details please.
> Fix it.
What are the userspace-visible runtime effects of this bug?
Thanks.
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -1456,6 +1456,8 @@ static int __init dynamic_debug_init(void)
> iter_mod_start = iter;
> }
> }
> +
> + mod_ct++;
> di.num_descs = mod_sites;
> di.descs = iter_mod_start;
> ret = ddebug_add_module(&di, modname);
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-08-30 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 12:18 [PATCH 0/2] dyndbg: fix incorrect mod_ct value in dynamic_debug_init() Yuntao Wang
2026-08-11 12:18 ` [PATCH 1/2] " Yuntao Wang
2026-08-30 3:23 ` Andrew Morton [this message]
2026-08-30 4:01 ` Yuntao Wang
2026-08-11 12:18 ` [PATCH 2/2] dyndbg: clean up dynamic_debug_init() to improve readability Yuntao Wang
2026-08-27 1:31 ` [PATCH 0/2] dyndbg: fix incorrect mod_ct value in dynamic_debug_init() Yuntao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829202306.67cf6ff7223b1bc33b57730d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yuntao.wang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.