From: sashiko-bot@kernel.org
To: "Leon Romanovsky" <leon@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 4/5] PCI/P2PDMA: Safely terminate ACS redirect lists
Date: Sun, 30 Aug 2026 11:22:08 +0000 [thread overview]
Message-ID: <20260830112208.AA0621F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260830-batch-p2p-fixes-v1-4-5044e8dfbe2e@nvidia.com>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> seq_buf marks an overflow by setting len to size + 1. The ACS diagnostic
> path unconditionally writes a terminator to buffer[len - 1], so a path
> with enough ACS ports to fill the 128-byte buffer writes one byte beyond
> the buffer when verbose diagnostics are requested.
>
> Use seq_buf_str() to terminate truncated output safely and remove the final
> semicolon only when the buffer did not overflow.
>
> Fixes: 52916982af48 ("PCI/P2PDMA: Support peer-to-peer memory")
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Tested-by: Tushar Dave <tdave@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260830-batch-p2p-fixes-v1-0-5044e8dfbe2e@nvidia.com?part=4
next prev parent reply other threads:[~2026-08-30 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 11:16 [PATCH 0/5] Batch of PCI peer-to-peer fixes Leon Romanovsky
2026-08-30 11:16 ` [PATCH 1/5] PCI/P2PDMA: Do not tear down the allocate attribute on registration failure Leon Romanovsky
2026-08-30 11:24 ` sashiko-bot
2026-08-30 11:16 ` [PATCH 2/5] PCI/P2PDMA: Wait for RCU readers before freeing state Leon Romanovsky
2026-08-30 11:23 ` sashiko-bot
2026-08-30 11:16 ` [PATCH 3/5] PCI/P2PDMA: Restrict the p2pmem search to pool backed providers Leon Romanovsky
2026-08-30 11:31 ` sashiko-bot
2026-08-30 11:16 ` [PATCH 4/5] PCI/P2PDMA: Safely terminate ACS redirect lists Leon Romanovsky
2026-08-30 11:22 ` sashiko-bot [this message]
2026-08-30 11:16 ` [PATCH 5/5] PCI/P2PDMA: Gate the host bridge whitelist warning on verbose Leon Romanovsky
2026-08-30 11:20 ` sashiko-bot
2026-09-09 2:18 ` Bjorn Helgaas
2026-09-10 15:25 ` Leon Romanovsky
2026-09-08 5:54 ` [PATCH 0/5] Batch of PCI peer-to-peer fixes Leon Romanovsky
2026-09-09 2:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830112208.AA0621F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=leon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.