From: Jakub Kicinski <kuba@kernel.org>
To: Miguel Garcia <miguelgarciaroman8@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, jacob.e.keller@intel.com,
syzbot+372a7d84708b07f64d9b@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org
Subject: Re: [PATCH net v2] devlink: request flash firmware without instance lock
Date: Sun, 30 Aug 2026 14:10:43 -0700 [thread overview]
Message-ID: <20260830141043.564ca0c6@kernel.org> (raw)
In-Reply-To: <20260830140157.5de02f7e@kernel.org>
On Sun, 30 Aug 2026 14:01:57 -0700 Jakub Kicinski wrote:
> On Sun, 30 Aug 2026 13:17:00 +0200 Miguel Garcia wrote:
> > request_firmware() may enter the userspace fallback and call
> > try_to_freeze(). Holding the devlink instance lock across that call
> > triggers a lockdep warning and can block unregister for the duration of
> > the firmware fallback.
> >
> > Drop the instance lock around firmware loading in both flash update paths.
> > The callers hold a devlink reference, which also pins the parent device.
> > Recheck registration after reacquiring the lock before calling into the
> > driver.
>
> How did you find this issue?
Ah, I missed the syzbot link. Sigh.
next prev parent reply other threads:[~2026-08-30 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 11:17 [PATCH net v2] devlink: request flash firmware without instance lock Miguel Garcia
2026-08-30 21:01 ` Jakub Kicinski
2026-08-30 21:10 ` Jakub Kicinski [this message]
2026-09-01 12:38 ` [PATCH net v3] devlink: use direct firmware requests for flash updates Miguel Garcia
2026-09-02 0:20 ` Andrew Lunn
2026-09-02 9:59 ` Miguel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830141043.564ca0c6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=miguelgarciaroman8@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+372a7d84708b07f64d9b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.