All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Koichiro Den" <den@valinux.co.jp>
Cc: ntb@lists.linux.dev, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 2/3] PCI: dw-rockchip: Support fixed MSI-X table and PBA on RK3588
Date: Sun, 30 Aug 2026 15:28:28 +0000	[thread overview]
Message-ID: <20260830152828.A468D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260830151948.3547577-3-den@valinux.co.jp>

> The RK3588 PCIe endpoint controller exposes its MSI-X table at
> BAR4+0x4000 and its PBA at BAR4+0x5000. Describe both as reserved regions
> so EPF drivers can select the hardware-owned layout.
> 
> The regular DesignWare MSI-X interrupt path reads an EPF-owned table
> through epf_bar[]. A reserved, hardware-owned table has no such backing.
> Record whether the layout selected for each function matches the
> hardware-owned layout, and use the controller MSI-X doorbell on RK3588
> only in that case. Continue to use the regular path for EPF-owned
> layouts.
> 
> Signed-off-by: Koichiro Den <den@valinux.co.jp>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260830151948.3547577-1-den@valinux.co.jp?part=2


  reply	other threads:[~2026-08-30 15:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 15:19 [PATCH v2 0/3] PCI: endpoint: Support hardware-owned MSI-X table and PBA Koichiro Den
2026-08-30 15:19 ` Koichiro Den
2026-08-30 15:19 ` [PATCH v2 1/3] " Koichiro Den
2026-08-30 15:19   ` Koichiro Den
2026-08-30 15:32   ` sashiko-bot
2026-08-30 15:19 ` [PATCH v2 2/3] PCI: dw-rockchip: Support fixed MSI-X table and PBA on RK3588 Koichiro Den
2026-08-30 15:19   ` Koichiro Den
2026-08-30 15:28   ` sashiko-bot [this message]
2026-08-30 15:19 ` [PATCH v2 3/3] PCI: endpoint: pci-epf-vntb: Honor MSI-X selection Koichiro Den
2026-08-30 15:19   ` Koichiro Den
2026-08-30 15:36   ` sashiko-bot
2026-08-31 10:24 ` [PATCH v2 0/3] PCI: endpoint: Support hardware-owned MSI-X table and PBA Niklas Cassel
2026-08-31 10:24   ` Niklas Cassel
2026-08-31 16:11   ` Koichiro Den
2026-08-31 16:11     ` Koichiro Den
2026-08-31 20:01     ` Niklas Cassel
2026-08-31 20:01       ` Niklas Cassel
2026-09-02  2:14       ` Koichiro Den
2026-09-02  2:14         ` Koichiro Den
2026-09-02  7:25         ` Niklas Cassel
2026-09-02  7:25           ` Niklas Cassel
2026-09-03  7:56           ` Koichiro Den
2026-09-03  7:56             ` Koichiro Den

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260830152828.A468D1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=den@valinux.co.jp \
    --cc=linux-pci@vger.kernel.org \
    --cc=ntb@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.