All of lore.kernel.org
 help / color / mirror / Atom feed
From: mdshahid03@gmail.com
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Mohammad Shahid" <mdshahid03@gmail.com>
Subject: [PATCH v2 0/5] iio: adc: bcm_iproc_adc: use device-managed resources
Date: Sun, 30 Aug 2026 22:39:13 +0530	[thread overview]
Message-ID: <20260830170919.470974-1-mdshahid03@gmail.com> (raw)

From: Mohammad Shahid <mdshahid03@gmail.com>

Changes since v1:

- Sort headers and make the driver IWYU compliant.
- Use devm_clk_get_enabled() and devm_add_action_or_reset() for
- clock and ADC cleanup.
- Use devm_mutex_init() and devm_iio_device_register(), removing
  the manual cleanup paths and remove() callback.

I checked the history of IPROC_ADC_AUXIN_SCAN_ENA and the related
iProc touchscreen driver. There is no documented dependency requiring
the bit to be cleared before tsc_clk is enabled.

I also checked the touchscreen driver's shared-register handling. It
enables tsc_clk before configuring the shared REGCTL2, and its
history does not indicate an ordering requirement involving
IPROC_ADC_AUXIN_SCAN_ENA.

Therefore, devm_clk_get_enabled() is used as suggested.

linux/delay.h is retained because the driver directly uses udelay().

---
Mohammad Shahid (5):
  iio: adc: bcm_iproc_adc: sort headers alphabetically
  iio: adc: bcm_iproc_adc: fix include dependencies
  iio: adc: bcm_iproc_adc: use devm-managed cleanup
  iio: adc: bcm_iproc_adc: use devm-managed mutex initialization
  iio: adc: bcm_iproc_adc: use devm_iio_device_register()

 drivers/iio/adc/bcm_iproc_adc.c | 62 ++++++++++++++-------------------
 1 file changed, 26 insertions(+), 36 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-08-30 17:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 17:09 mdshahid03 [this message]
2026-08-30 17:09 ` [PATCH v2 1/5] iio: adc: bcm_iproc_adc: sort headers alphabetically mdshahid03
2026-08-30 17:09 ` [PATCH v2 2/5] iio: adc: bcm_iproc_adc: fix include dependencies mdshahid03
2026-09-01  2:27   ` Marcelo Schmitt
2026-09-01  3:16     ` Jonathan Cameron
2026-09-01  6:57     ` Andy Shevchenko
2026-08-30 17:09 ` [PATCH v2 3/5] iio: adc: bcm_iproc_adc: use devm-managed cleanup mdshahid03
2026-08-30 20:18   ` Jonathan Cameron
2026-08-30 17:09 ` [PATCH v2 4/5] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization mdshahid03
2026-08-30 17:09 ` [PATCH v2 5/5] iio: adc: bcm_iproc_adc: use devm_iio_device_register() mdshahid03
2026-08-30 20:18   ` Jonathan Cameron
2026-09-01  2:13   ` Marcelo Schmitt
2026-09-01 14:40 ` [PATCH v2 0/5] iio: adc: bcm_iproc_adc: use device-managed resources mdshahid03
2026-09-04 22:25   ` Marcelo Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260830170919.470974-1-mdshahid03@gmail.com \
    --to=mdshahid03@gmail.com \
    --cc=andy@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.