Re: [PATCH 2/3] arm64: dts: qcom: add HP OmniBook Ultra 14-kg0xxx

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] 1.8V regulator applied to 1.2V and 0.95V pins on the WCN7850 PMU, risking hardware damage.
- [Low] The board device tree references an undefined `&pcie3_phy` label, causing a dtc compilation failure.
--

commit 4454af8cdf9bffc654c2251cf576014586466b4c
Author: Jason Pettit <jason.pettit@oss.qualcomm.com>

arm64: dts: qcom: add HP OmniBook Ultra 14-kg0xxx
    
Add board support for HP OmniBook Ultra 14" Next Gen AI PC
(product SKU D29KLAS#ABA, board 8F03), a Snapdragon X2 Elite (Glymur)
laptop, using the "hp,omnibook-ultra-kg0xxx" / "qcom,glymur" compatible.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-hp-omnibook-ultra-kg0xxx.dts b/arch/arm64/boot/dts/qcom/glymur-hp-omnibook-ultra-kg0xxx.dts
> new file mode 100644
> index 0000000000000..d1c1880a50b9b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-hp-omnibook-ultra-kg0xxx.dts

[ ... ]

> +	wcn7850-pmu {
> +		compatible = "qcom,wcn7850-pmu";
> +		vdd-supply = <&vreg_wcn_0p95>;
> +		vddaon-supply = <&vreg_l15b_e0_1p8>;
> +		vdddig-supply = <&vreg_l15b_e0_1p8>;
> +		vddio-supply = <&vreg_l15b_e0_1p8>;
> +		vddio1p2-supply = <&vreg_l15b_e0_1p8>;
> +		vddrfa1p2-supply = <&vreg_l15b_e0_1p8>;
> +		vddrfa1p8-supply = <&vreg_l15b_e0_1p8>;

[Severity: High]
Does this apply a 1.8V supply (vreg_l15b_e0_1p8) to pins that structurally
require 1.2V (vddio1p2, vddrfa1p2) and ~0.95V (vddaon, vdddig)?

Over-volting these inputs with a 1.8V supply risks permanently damaging the
WCN7850 PMU or causing system instability. A 1.2V regulator (vreg_l18b_e0_1p2)
is defined in this file but appears incorrectly unused here.

[ ... ]

> +&pcie3_phy {
> +	vdda-phy-supply = <&vreg_l3c_e1_0p94>;
> +	vdda-pll-supply = <&vreg_l2c_e1_1p2>;
> +
> +	vdda-refgen0p9-supply = <&vreg_l1c_e1_0p91>;
> +	vdda-refgen1p2-supply = <&vreg_l4f_e1_1p2>;
> +
> +	status = "okay";
> +};

[Severity: Low]
Does this reference an undefined pcie3_phy label?

Since pcie3_phy is not defined in glymur.dtsi (unlike older SoCs where it
might have been copied from), this reference will cause a dtc compilation
failure when building the device tree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260830-x2-hp-omnibook-ship-v1-0-9feada71dc79@oss.qualcomm.com?part=2