All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Rys <martin@archlinux.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] USB: Improve "New device found" printout message
Date: Sun, 30 Aug 2026 10:14:33 +0200	[thread overview]
Message-ID: <2026083035-sadden-eastcoast-19c3@gregkh> (raw)
In-Reply-To: <85d0669f-9e7b-4e53-a403-3b6021c837ed@archlinux.org>

On Sun, Aug 30, 2026 at 09:56:15AM +0200, Martin Rys wrote:
> > Nit, why is this in the body of the email?
> 
> It's the raw output from `git format-patch -1 HEAD -v2`.
> 
> Other than by implication in the "canonical patch format" section, 
> neither of these docs seem to have a mention to delete any of the 
> 4 lines that I could find:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> https://www.kernel.org/doc/html/latest/process/email-clients.html
> 
> I see that the first line is some compatibility start of message marker,
> so I am guessing that's not needed in any case when using Thunderbird.
> 
> Not that it's important, but is it possible to keep the Date: in, 
> to retain the commit message time?

Those headers are emulating a mail message, you don't have to include
them again in the body of the email.

The date will be when you send the email, not when the patch was made on
your local machine.  If you use something like git send-email or b4 to
send the patch, those headers are not included.  If you use thunderbird,
that's great, don't include them either, just like if you use a tool
like mutt (which I do for many patches), you don't include the headers.

thanks,

greg k-h

      reply	other threads:[~2026-08-30  8:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 18:38 [PATCH v2] USB: Improve "New device found" printout message Martin Rys
2026-08-30  6:21 ` Greg KH
2026-08-30  7:56   ` Martin Rys
2026-08-30  8:14     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026083035-sadden-eastcoast-19c3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin@archlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.