[BlueZ PATCH 3/3] shared/mcp: Notify unsupported RFU opcodes

[raghu447 <raghavendra.rao@collabora.com>]

From: raghavendra <raghavendra.rao@collabora.com>

This is needed to Pass PTS GMCS/SR/SPE/BI-01-C test.
---
 src/shared/mcp.c |  4 +++-
 unit/test-mcp.c  | 14 ++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/shared/mcp.c b/src/shared/mcp.c
index a954869b0..583ae40dc 100644
--- a/src/shared/mcp.c
+++ b/src/shared/mcp.c
@@ -324,6 +324,7 @@ static void write_media_cp(struct gatt_db_attribute *attrib,
 	int ret = 0;
 	int32_t arg = 0;
 	uint8_t op;
+	bool rfu_op = false;
 	bool ok = false;
 
 	if (offset) {
@@ -337,6 +338,7 @@ static void write_media_cp(struct gatt_db_attribute *attrib,
 	}
 
 	rsp.op = op;
+	rfu_op = !op;
 
 	cmd = mcs_get_command(op);
 	if (!cmd || !(cmd->support & mcs_get_supported(mcs))) {
@@ -370,7 +372,7 @@ respond:
 							ret, rsp.result);
 
 	gatt_db_attribute_write_result(attrib, id, ret);
-	if (!rsp.op)
+	if (!rsp.op && !rfu_op)
 		return;
 
 	/* Make state transition immediately if command was successful and has
diff --git a/unit/test-mcp.c b/unit/test-mcp.c
index 6331c6c99..21997915d 100644
--- a/unit/test-mcp.c
+++ b/unit/test-mcp.c
@@ -2057,6 +2057,19 @@ static void testgroup_sr_mcp(void)
 }
 
 
+#define GMCS_SR_SPE_BI_01_C \
+	WRITE_NORESP_CHRC(CP, 0x00), \
+	NOTIFY_CHRC(CP, 0x00, 0x02 /* not supp */)
+
+static void testgroup_sr_spe(void)
+{
+	define_test("GMCS/SR/SPE/BI-01-C [Media Control Point - Opcode not "
+							"Supported]",
+		test_setup_server, test_server,
+		&cfg_sggit_gmcs, GMCS_SR_SPE_BI_01_C);
+}
+
+
 static void sr_spn_value(struct test_data *data, struct iovec *buf, size_t size,
 								uint16_t uuid)
 {
@@ -2132,6 +2145,7 @@ int main(int argc, char *argv[])
 	testgroup_cl_extra();
 	testgroup_sr_sggit();
 	testgroup_sr_mcp();
+	testgroup_sr_spe();
 	testgroup_sr_spn();
 
 	return tester_run();