Re: [PATCH 2/7] xfs: port healthmon event list to list_head

[Christoph Hellwig <hch@lst.de>]

On Wed, Aug 26, 2026 at 10:32:59PM -0700, Darrick J. Wong wrote:
>  struct xfs_healthmon_event {
> -	struct xfs_healthmon_event	*next;
> +	struct list_head		list;

Call this entry to make clear it's a list entry and not the list?

> +static inline struct xfs_healthmon_event *xfs_healthmon_alloc_event(void)
> +{
> +	struct xfs_healthmon_event		*event =
> +		kzalloc_obj(struct xfs_healthmon_event, GFP_NOFS);
> +
> +	if (event)
> +		INIT_LIST_HEAD(&event->list);
> +	return event;

There is no need to initialize a list_head only used as an entry.

> +}
> +
> +static inline struct xfs_healthmon_event *
> +xfs_healthmon_dup_event(
> +	const struct xfs_healthmon_event	*template)
> +{
> +	struct xfs_healthmon_event		*event =
> +		kmemdup(template, sizeof(struct xfs_healthmon_event),
> +				GFP_NOFS);
> +
> +	if (event)
> +		INIT_LIST_HEAD(&event->list);
> +	return event;

Same here.