Re: [PATCH v43 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Schema Validation Incompleteness: New compatible string `fsl,imx95-se-ele-hsm` is missing from the `memory-region` conditional block.
--

commit 5a206151babf3f7ce0f11bd9494abfd29942086c
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

dt-bindings: arm: fsl: add imx-se-fw binding doc

This commit adds the device tree binding documentation for the NXP HW Secure
Enclave EdgeLock Enclave. It defines compatible strings and required properties
such as mboxes, memory-region, and sram.

> diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
> new file mode 100644
> index 0000000000000..fa81adbf9b80d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml

[ ... ]

> +allOf:
> +  # memory-region
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx8ulp-se-ele-hsm
> +              - fsl,imx93-se-ele-hsm

[Severity: Medium]
Does the newly added fsl,imx95-se-ele-hsm compatible string also require a
memory region?

If imx95 shares this constraint with imx8ulp and imx93, omitting it from this
conditional block means device trees for imx95 that incorrectly omit the
memory-region property may silently pass validation. Valid configurations might
also fail because the fallback else clause sets memory-region: false.

> +    then:
> +      required:
> +        - memory-region
> +    else:
> +      properties:
> +        memory-region: false
> +
> +  # sram

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-imx-se-if-v43-0-a3deadbda4ef@nxp.com?part=2