Re: [PATCH v5 4/4] drm/xe/gt: Report GT reset failure using SIGID

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect time unit in GT reset failure log message (reports 5000 ms instead of 5 ms / 5000 us)
--

commit 4b084e884bdfae225e6341823adbd51d6b4fd3dd
Author: Arvind Yadav <arvind.yadav@intel.com>

drm/xe/gt: Report GT reset failure using SIGID

This commit routes the GT reset failure log through the structured SIGID
logging helper using the GT component. It also updates the error message
to describe that the full graphics reset did not complete within the timeout.

> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 478e047031f4f..18a6d5a6686ca 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -830,8 +830,8 @@ static int do_gt_reset(struct xe_gt *gt)
>  	xe_mmio_write32(&gt->mmio, GDRST, GRDOM_FULL);
>  	err = xe_mmio_wait32(&gt->mmio, GDRST, GRDOM_FULL, 0, 5000, NULL, false);
>  	if (err)
> -		xe_gt_err(gt, "failed to clear GRDOM_FULL (%pe)\n",
> -			  ERR_PTR(err));
> +		xe_log_err(gt, GT, err,
> +			   "full graphics reset not completed in %u ms\n", 5000);

[Severity: Low]
Does this log message in do_gt_reset() report the wrong time unit? 

The timeout parameter passed to xe_mmio_wait32() right before this is 5000
microseconds, but the new error message hardcodes "5000 ms" (5 seconds).
Reporting 5000 ms might significantly mislead anyone diagnosing GT reset
failures into believing the driver waited 1000x longer than it actually did.
Should this be updated to say "5 ms" or "5000 us" to accurately reflect the
wait time?

>  
>  	xe_gsc_wa_14015076503(gt, false);
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831080507.2364687-1-arvind.yadav@intel.com?part=4