Re: [PATCH v8 4/5] dt-bindings: arm: fsl: add compatible for new Skov i.MX8MP variant

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string is added to a 2-item schema block, but its device tree uses a 3-item compatible array, which will fail dtbs_check.
--

commit 431593d91ace715961413533bdc962a1b95958b2
Author: Steffen Trumtrar <s.trumtrar@pengutronix.de>

dt-bindings: arm: fsl: add compatible for new Skov i.MX8MP variant

In preparation for adding a new device tree variant with a different 7"
panel, this commit describes the DT compatible in the binding.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 55d0b682a7305..aaa9d18a241f8 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1147,6 +1147,7 @@ properties:
>                - skov,imx8mp-skov-revb-mi1010ait-1cp1 # SKOV i.MX8MP climate control with 10.1" panel
>                - skov,imx8mp-skov-revc-hdmi # SKOV i.MX8MP climate control without panel
>                - skov,imx8mp-skov-revc-bd500 # SKOV i.MX8MP climate control with LED frontplate
> +              - skov,imx8mp-skov-revc-jutouch-jt070tm041 # SKOV i.MX8MP climate control with 7" JuTouch panel

[Severity: Low]
Will this compatible string definition cause schema validation to fail when
dtbs_check is run?

The new compatible string is being added to an items array under a oneOf
branch that expects exactly two items (the board string followed by
"fsl,imx8mp").

However, as introduced in the follow-up patch, the device tree defines three
compatible strings:

    compatible = "skov,imx8mp-skov-revc-jutouch-jt070tm041",
                 "skov,imx8mp-skov-revc-touch",
                 "fsl,imx8mp";

Could this cause dtbs_check to flag the three-item array as too long?

>                - skov,imx8mp-skov-revc-jutouch-jt101tm023 # SKOV i.MX8MP climate control with 10" JuTouch panel
>                - skov,imx8mp-skov-revc-tian-g07017 # SKOV i.MX8MP climate control with 7" panel
>                - skov,imx8mp-skov-revc-touch # SKOV i.MX8MP climate control revision C with touch panel

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v8-0-e2e635452ba9@pengutronix.de?part=4