From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 506F1C61DD3 for ; Mon, 31 Aug 2026 08:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iM6Np2db9iLL29y316qSFxGDYWMLhe3xi/l4vz5DQTY=; b=fwR4hvOk1mFoKc 49wHGdf4tGGOydW2lmdHBBL9UyLTEo0zB2gkzT7XpPnCO5JWnlbFpX6aBOjyz1A3cV8nzsKzJBIGE kGO41d8DTB1FPUWhBP4V0KIC3mHMYYmIUwBouxANWJMbSYykvJCCfkeX/OhjB9eXnYURN1vzgB3Om KssqvACNRZ00sXk/QkFS9/I2lFkWNlc5U6pufb+gwWs7KzqFrtio2sa33KC7rzgz3IAFvsHi28Zxh hmivrnqavDCzWpSBP6eRdww/3xcrGSfrUKEXOZabPowj61SC7g/kI2ycX+vFJuLFG6GbX/RuPBqwt D1nUGf3hDOH1qY9olJzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x0xbM-00000008vga-2PCT; Mon, 31 Aug 2026 08:42:48 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x0xbL-00000008vgU-0Ck4 for linux-amlogic@lists.infradead.org; Mon, 31 Aug 2026 08:42:47 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2D1EE601FB; Mon, 31 Aug 2026 08:42:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7960A1F00A3D; Mon, 31 Aug 2026 08:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788165765; bh=Vvg3sfOFpv/DBqo2re/qrS5jT9iJB0JgddHp+qkdo2w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=R4ajlRmbQIuQCKq+DaeMqjNYNaz9vupn/ez8Uzir58RSY/3HkG2Wd45qbyw5sNKqE 3O1gZKO+0Qu3zRhTWLe3Aw55KLhPcTQ54n6WfyYgODU6svpExvwU4KMMjH7j8Ap6Dt gSVp8RGrLIqgLlhR70gzZhAEjv2Dn1f0hDwFNjAHcqYpbyIn6lVHq8LBGmu3U7Bb00 dPNwRVnbw4pskbY1nWhZ2n67Ae6OELIotdM+vmU+uEH82E5crPe5YABCkzB6laljd4 g/wHzk6pqRvlT1HhDVu0dkZ86tLGw009TifmhL8qVkyfqA7zArMdPQjOMqaKrRq5Ki EHJxoJneeFGIg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder To: "Zhentao Guo" Cc: media-ci@linuxtv.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-3-830195b9bd91@amlogic.com> References: <20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com> <20260831-b4-s4-vdec-upstream-v8-3-830195b9bd91@amlogic.com> Date: Mon, 31 Aug 2026 08:42:44 +0000 Message-Id: <20260831084245.7960A1F00A3D@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIGJpbmRpbmcgc3Bl Y2lmaWVzIHVwIHRvIDIgaW50ZXJydXB0cyBidXQgbGFja3MgYW4gJ2l0ZW1zJyBsaXN0IHdpdGgg ZGVzY3JpcHRpb25zIG9yIGFuICdpbnRlcnJ1cHQtbmFtZXMnIHByb3BlcnR5IHRvIGlkZW50aWZ5 IHRoZW0uCi0tCgpjb21taXQgOTZjOGE3ZjNkMTJmYTUwNTk1NjRhNTZmZGVkZDZhNzdjNzZkNjhj YgpBdXRob3I6IFpoZW50YW8gR3VvIDx6aGVudGFvLmd1b0BhbWxvZ2ljLmNvbT4KCm1lZGlhOiBk dC1iaW5kaW5nczogQWRkIEFtbG9naWMgVjRMMiB2aWRlbyBkZWNvZGVyCgpEZXNjcmliZSB0aGUg aW5pdGlhbCBzdXBwb3J0IGZvciB0aGUgVjRMMiBzdGF0ZWxlc3MgdmlkZW8gZGVjb2RlciBkcml2 ZXIgdXNlZAp3aXRoIHRoZSBBbWxvZ2ljIFM0IChTODA1WDIpIHBsYXRmb3JtLgoKPiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lZGlhL2FtbG9naWMsczQt dmRlYy55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lZGlhL2FtbG9n aWMsczQtdmRlYy55YW1sCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAw MDAwLi5hOTNhMjE0MDgwMWI5Cj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9hbWxvZ2ljLHM0LXZkZWMueWFtbApbIC4uLiBdCj4g KyAgcmVnLW5hbWVzOgo+ICsgICAgaXRlbXM6Cj4gKyAgICAgIC0gY29uc3Q6IGRvcwo+ICsgICAg ICAtIGNvbnN0OiBkbWMKPiArCj4gKyAgaW50ZXJydXB0czoKPiArICAgIG1heEl0ZW1zOiAyCgpb U2V2ZXJpdHk6IExvd10KRG9lcyB0aGlzIHByb3BlcnRpZXMuaW50ZXJydXB0cyBiaW5kaW5nIGFs bG93IHVwIHRvIDIgaW50ZXJydXB0cyB3aXRob3V0CnByb3ZpZGluZyBhbiAnaXRlbXMnIGxpc3Qg d2l0aCBkZXNjcmlwdGlvbnMgb3IgYW4gJ2ludGVycnVwdC1uYW1lcycgcHJvcGVydHkgdG8KaWRl bnRpZnkgdGhlbT8KClNpbmNlIHRoZSBkcml2ZXIgdXNlcyBwbGF0Zm9ybV9nZXRfaXJxKHBkZXYs IElSUV9WREVDKSAod2hlcmUgSVJRX1ZERUMgaXMgMSksCml0IHJlbGllcyBzdHJpY3RseSBvbiB0 aGUgaW5kZXggb3JkZXIuIENvdWxkIHRoaXMgbWFrZSB0aGUgYmluZGluZ3MgaGFyZGVyIHRvCnVz ZSBjb3JyZWN0bHkgYW5kIGxlYWQgdG8gYnJva2VuIGludGVycnVwdHMgaWYgYSBkZXZpY2UgdHJl ZSBhdXRob3IgZ3Vlc3NlcyB0aGUKd3Jvbmcgb3JkZXIgd2hlbiBjb25zdHJ1Y3RpbmcgYSBuZXcg Ym9hcmQ/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3Bh dGNoc2V0LzIwMjYwODMxLWI0LXM0LXZkZWMtdXBzdHJlYW0tdjgtMC04MzAxOTViOWJkOTFAYW1s b2dpYy5jb20/cGFydD0zCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306703AEF59 for ; Mon, 31 Aug 2026 08:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788165767; cv=none; b=hIlO/7ounJMZqlKw4FiUOuy/ZyDzvVzaDsAJqo8O5pdEZj5IVXla/wutFSuaJGdCkn5tlbkKRp5sDCTJVMbDNFahARt2CoNURJe1EsUpqaFT4YD4jUtzUCLNrgYksN6cPMiNilcWciWukNV7IaRmojVgujg1v7UtdRESy2VvNlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788165767; c=relaxed/simple; bh=Rwe0GCwO7ASl44P0Eertrbhqzrq6LpgeS1FZqPsnq3g=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=nej7/0zAfHga7J2fOlJ4bDvjOqTuQVySlc4/PpP2FkEeXuT6Ot5Gn7dQpglwq3nRm+BFswAZQJjgeSy9YIQwlrOKePv1yjjTZeILkk+91IJ6Igu0ayy8SG48ViXgwG51GPWcJWemSN15TKT3b7Min1fpb3UUE+WVI+2ija7OR0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R4ajlRmb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R4ajlRmb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7960A1F00A3D; Mon, 31 Aug 2026 08:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788165765; bh=Vvg3sfOFpv/DBqo2re/qrS5jT9iJB0JgddHp+qkdo2w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=R4ajlRmbQIuQCKq+DaeMqjNYNaz9vupn/ez8Uzir58RSY/3HkG2Wd45qbyw5sNKqE 3O1gZKO+0Qu3zRhTWLe3Aw55KLhPcTQ54n6WfyYgODU6svpExvwU4KMMjH7j8Ap6Dt gSVp8RGrLIqgLlhR70gzZhAEjv2Dn1f0hDwFNjAHcqYpbyIn6lVHq8LBGmu3U7Bb00 dPNwRVnbw4pskbY1nWhZ2n67Ae6OELIotdM+vmU+uEH82E5crPe5YABCkzB6laljd4 g/wHzk6pqRvlT1HhDVu0dkZ86tLGw009TifmhL8qVkyfqA7zArMdPQjOMqaKrRq5Ki EHJxoJneeFGIg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Reply-To: sashiko-reviews@lists.linux.dev To: "Zhentao Guo" Cc: media-ci@linuxtv.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-3-830195b9bd91@amlogic.com> References: <20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com> <20260831-b4-s4-vdec-upstream-v8-3-830195b9bd91@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 31 Aug 2026 08:42:44 +0000 Message-Id: <20260831084245.7960A1F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The binding specifies up to 2 interrupts but lacks an 'items' list = with descriptions or an 'interrupt-names' property to identify them. -- commit 96c8a7f3d12fa5059564a56fdedd6a77c76d68cb Author: Zhentao Guo media: dt-bindings: Add Amlogic V4L2 video decoder Describe the initial support for the V4L2 stateless video decoder driver us= ed with the Amlogic S4 (S805X2) platform. > diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml= b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml > new file mode 100644 > index 0000000000000..a93a2140801b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml [ ... ] > + reg-names: > + items: > + - const: dos > + - const: dmc > + > + interrupts: > + maxItems: 2 [Severity: Low] Does this properties.interrupts binding allow up to 2 interrupts without providing an 'items' list with descriptions or an 'interrupt-names' propert= y to identify them? Since the driver uses platform_get_irq(pdev, IRQ_VDEC) (where IRQ_VDEC is 1= ), it relies strictly on the index order. Could this make the bindings harder = to use correctly and lead to broken interrupts if a device tree author guesses= the wrong order when constructing a new board? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260831-b4-s4-vdec= -upstream-v8-0-830195b9bd91@amlogic.com?part=3D3