From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05A73C61DD3 for ; Mon, 31 Aug 2026 08:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iIq1cpf2O7MR3jqaOlM4H1JhvNqeHC3Iom/sU7dcYgo=; b=ZO2k27OZYtksdr t6ZINU6wFLtJb1YMVJpMzTvWFGIhT7bHw/eRubJBKaLQbKtl1YK94juxv0DK9GoRFPRA7R9Q8rkfH 2hDYhr2ifO0Nvq8hybaLj+1Jz6GupimayE7u437OTMWgeNHJgqCDQbxcu5VK2I6tH5zCmS48/vAGJ K/xi1Ueu0HcnS6vIh/DX1T1MqUtw+ZberPMDYmmISLmUroUgs6a/lmR4ed6xTOUWmZmzSLIMXfwtR 5DqljR7R4Z0ToErtEEyCDKp/luaOYJqBUyheltBLG62g2GDyWjEVDctWsMNHOpkxyKkF8gdtJgXPw Otq18FFIIWkpPOwSzafw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x0xe8-00000008w6M-1IH3; Mon, 31 Aug 2026 08:45:40 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x0xe6-00000008w6G-3p29 for linux-amlogic@lists.infradead.org; Mon, 31 Aug 2026 08:45:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5969A6013A; Mon, 31 Aug 2026 08:45:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AF4E1F000E9; Mon, 31 Aug 2026 08:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788165938; bh=RBaKEzy3WJAZ5/M7he4aAXq1NYfHuJ13s4feY8ly5Bw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Xpe2axprfLzQD493mgU8258l1x8RoBrns+nWZJRgHKCiTA49DCmn+VhS1SJUrufkr 5qTy+FvrWurKJ+QbyL2MyN5xZHFKiiZVIEln0GYZGVx9Y/hXv9pzsKsFogI4QsNMjJ rYQ5rtocjR/PGv4ola6iY04ZLF0Q9S9yUO931Yq7Uffg3ihSE1A57cXYxIjSERdCcD cDab5x2VE1wc7HfO4VUYwqnW8fRMiue2vN3vZ72WYcHuP/L3tUe9JJBdiwaNKNjfs2 NULxcULX6oNafNNf7fokECIPL81FCUCpY7eaqgirbWM+VtJeULHt/p9Tlvszp6IKTn TqpKrOtAn4TXA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 2/6] firmware: meson: sm: Add video firmware loading SMC call To: "Zhentao Guo" Cc: conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, media-ci@linuxtv.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-2-830195b9bd91@amlogic.com> References: <20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com> <20260831-b4-s4-vdec-upstream-v8-2-830195b9bd91@amlogic.com> Date: Mon, 31 Aug 2026 08:45:37 +0000 Message-Id: <20260831084537.9AF4E1F000E9@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBtZXNvbl9zbV9jYWxsKCkgdW5jb25kaXRpb25hbGx5IHJldHVybnMgMCBvbiBzdWNj ZXNzZnVsIGNvbW1hbmQgZGlzcGF0Y2gsIG1hc2tpbmcgU01DQ0MgZXJyb3JzIGZyb20gZnVuY3Rp b25zIHRoYXQgcmVseSBvbiBpdHMgcmV0dXJuIHZhbHVlIGluc3RlYWQgb2YgY2hlY2tpbmcgdGhl IG91dHB1dCBwYXJhbWV0ZXIuCi0tCgpjb21taXQgOWRkZTFjNDRkODA2NWRiZjcxZjQ1MmRlZTI2 OTRkOTMyZmEzZDZhZQpBdXRob3I6IFpoZW50YW8gR3VvIDx6aGVudGFvLmd1b0BhbWxvZ2ljLmNv bT4KCmZpcm13YXJlOiBtZXNvbjogc206IEFkZCB2aWRlbyBmaXJtd2FyZSBsb2FkaW5nIFNNQyBj YWxsCgpUaGlzIGNvbW1pdCBhZGRzIHRoZSBTTV9MT0FEX1ZJREVPX0ZXIGNvbW1hbmQgdG8gdGhl IGd4YmJfY2hpcCBjb21tYW5kCnRhYmxlIHdpdGggU01DIElEIDB4YjIwMDAwMGYgZm9yIGxvYWRp bmcgdmlkZW8gZmlybXdhcmUuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Zpcm13YXJlL21lc29u L21lc29uX3NtLmMgYi9kcml2ZXJzL2Zpcm13YXJlL21lc29uL21lc29uX3NtLmMKPiBpbmRleCBh Yjk3NTFhNTliNTUyLi44ODdjYWE1YzYyNWRiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZmlybXdh cmUvbWVzb24vbWVzb25fc20uYwo+ICsrKyBiL2RyaXZlcnMvZmlybXdhcmUvbWVzb24vbWVzb25f c20uYwo+IEBAIC00OCw2ICs0OCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWVzb25fc21fY2hp cCBneGJiX2NoaXAgPSB7Cj4gIAkJQ01EKFNNX1RIRVJNQUxfQ0FMSUJfUkVBRCwJMHg4MjAwMDA0 NyksCj4gIAkJQ01EKFNNX0ExX1BXUkNfU0VULAkJMHg4MjAwMDA5MyksCj4gIAkJQ01EKFNNX0Ex X1BXUkNfR0VULAkJMHg4MjAwMDA5NSksCj4gKwkJQ01EKFNNX0xPQURfVklERU9fRlcsCQkweGIy MDAwMDBmKSwKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwg YnV0IGRvZXMgbWVzb25fc21fY2FsbCgpIGhhbmRsZSBTTUNDQwplcnJvcnMgY29ycmVjdGx5PwoK TG9va2luZyBhdCBtZXNvbl9zbV9jYWxsKCksIGl0IHVuY29uZGl0aW9uYWxseSByZXR1cm5zIDAg YWZ0ZXIgZGlzcGF0Y2hpbmcKdGhlIGNvbW1hbmQ6Cgpkcml2ZXJzL2Zpcm13YXJlL21lc29uL21l c29uX3NtLmM6bWVzb25fc21fY2FsbCgpIHsKICAgIC4uLgoJbHJldCA9IF9fbWVzb25fc21fY2Fs bChjbWQsIGFyZzAsIGFyZzEsIGFyZzIsIGFyZzMsIGFyZzQpOwoKCWlmIChyZXQpCgkJKnJldCA9 IGxyZXQ7CgoJcmV0dXJuIDA7Cn0KClRoaXMgbWFza3MgU01DQ0MgZXJyb3JzIGZyb20gY2FsbGVy cyB0aGF0IHJlbHkgb24gaXRzIHJldHVybiB2YWx1ZSBpbnN0ZWFkCm9mIGNoZWNraW5nIHRoZSBv dXRwdXQgcGFyYW1ldGVyLiBGb3IgZXhhbXBsZSwgdGhlIHBvd2VyIGRvbWFpbiBkcml2ZXIKKGRy aXZlcnMvcG1kb21haW4vYW1sb2dpYy9tZXNvbi1zZWN1cmUtcHdyYy5jKSBwYXNzZXMgYSBOVUxM IHBvaW50ZXIgZm9yCnRoZSBvdXRwdXQgcGFyYW1ldGVyIGFuZCByZWxpZXMgb24gdGhlIHJldHVy biB2YWx1ZSBvZiBtZXNvbl9zbV9jYWxsKCkKZm9yIGVycm9yIGNoZWNraW5nLiBUaGlzIGNhdXNl cyBpdCB0byBhc3N1bWUgcG93ZXIgb3BlcmF0aW9ucyBhbHdheXMKc3VjY2VlZCwgd2hpY2ggY291 bGQgbGVhZCB0byBhIHN5bmNocm9ub3VzIGV4dGVybmFsIGFib3J0IChrZXJuZWwgcGFuaWMpCmlm IGhhcmR3YXJlIHdpdGhpbiBhIGZhaWxlZCBwb3dlciBkb21haW4gaXMgYWNjZXNzZWQuCgpTaW1p bGFybHksIG1lc29uX3NtX2dldF90aGVybWFsX2NhbGliKCkgcGFzc2VzIGEgcG9pbnRlciB0byBy ZWNlaXZlCmNhbGlicmF0aW9uIGRhdGEsIGJ1dCBpZiBhbiBlcnJvciBvY2N1cnMsIHRoZSBTTUMg ZXJyb3IgY29kZSBpcyBkaXJlY3RseQp3cml0dGVuIGludG8gdGhpcyBkYXRhLCBhbmQgdGhlIGZ1 bmN0aW9uIGluY29ycmVjdGx5IHJldHVybnMgMCAoc3VjY2Vzcyk6Cgpkcml2ZXJzL2Zpcm13YXJl L21lc29uL21lc29uX3NtLmM6bWVzb25fc21fZ2V0X3RoZXJtYWxfY2FsaWIoKSB7CiAgICAuLi4K CXJldHVybiBtZXNvbl9zbV9jYWxsKGZ3LCBTTV9USEVSTUFMX0NBTElCX1JFQUQsIHRyaW1faW5m bywgdHNlbnNvcl9pZCwKCQkJICAgICAwLCAwLCAwLCAwKTsKfQoKU2hvdWxkIG1lc29uX3NtX2Nh bGwoKSBwcm9wYWdhdGUgdGhlIGVycm9yIGNvZGUgaW4gbHJldCBpbnN0ZWFkIG9mIGFsd2F5cwpy ZXR1cm5pbmcgMD8KCj4gIAkJeyAvKiBzZW50aW5lbCAqLyB9LAo+ICAJfSwKPiAgfTsKCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4 MzEtYjQtczQtdmRlYy11cHN0cmVhbS12OC0wLTgzMDE5NWI5YmQ5MUBhbWxvZ2ljLmNvbT9wYXJ0 PTIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE623CAA31 for ; Mon, 31 Aug 2026 08:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788165939; cv=none; b=FiBSUTIc3NtVIWnDJm0m0xq5+iuHLBk7M4DPXTm9s2O7RqtXjXzS+NZ4w8ovVzeV+1ca0ZHx/U+bLiUcM+FNFI/JcQewyq7uKbxPqvy04lod4h4xLPmUJGIp+TkaxqnFHFmeYQmqeOFQbAC3T1n1t1q3LdoY/hxT2vYdKAQASUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788165939; c=relaxed/simple; bh=VE1ogEBUwe9NH3lAU37yIZeiuYSVW5+71nT+V1WfXYA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=dGSBXk3dzfF+31iSGRcEyiEpzlDTqsv5W3kgwVI3OBjhJz40SDQdkeNPG/9u+kojkmrRlMlSk4oRWH5EYI6DlGeXkCPXg+gBh1pXv59qSP5g+pK3Reg74a8X6Z+fpDB6d0TIhHm+jKTsQZRpZlwlW6bfronoffFSPg4LZPfMqZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xpe2axpr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xpe2axpr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AF4E1F000E9; Mon, 31 Aug 2026 08:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788165938; bh=RBaKEzy3WJAZ5/M7he4aAXq1NYfHuJ13s4feY8ly5Bw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Xpe2axprfLzQD493mgU8258l1x8RoBrns+nWZJRgHKCiTA49DCmn+VhS1SJUrufkr 5qTy+FvrWurKJ+QbyL2MyN5xZHFKiiZVIEln0GYZGVx9Y/hXv9pzsKsFogI4QsNMjJ rYQ5rtocjR/PGv4ola6iY04ZLF0Q9S9yUO931Yq7Uffg3ihSE1A57cXYxIjSERdCcD cDab5x2VE1wc7HfO4VUYwqnW8fRMiue2vN3vZ72WYcHuP/L3tUe9JJBdiwaNKNjfs2 NULxcULX6oNafNNf7fokECIPL81FCUCpY7eaqgirbWM+VtJeULHt/p9Tlvszp6IKTn TqpKrOtAn4TXA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 2/6] firmware: meson: sm: Add video firmware loading SMC call Reply-To: sashiko-reviews@lists.linux.dev To: "Zhentao Guo" Cc: conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, media-ci@linuxtv.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-2-830195b9bd91@amlogic.com> References: <20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com> <20260831-b4-s4-vdec-upstream-v8-2-830195b9bd91@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 31 Aug 2026 08:45:37 +0000 Message-Id: <20260831084537.9AF4E1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] meson_sm_call() unconditionally returns 0 on successful command di= spatch, masking SMCCC errors from functions that rely on its return value i= nstead of checking the output parameter. -- commit 9dde1c44d8065dbf71f452dee2694d932fa3d6ae Author: Zhentao Guo firmware: meson: sm: Add video firmware loading SMC call This commit adds the SM_LOAD_VIDEO_FW command to the gxbb_chip command table with SMC ID 0xb200000f for loading video firmware. > diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/m= eson_sm.c > index ab9751a59b552..887caa5c625db 100644 > --- a/drivers/firmware/meson/meson_sm.c > +++ b/drivers/firmware/meson/meson_sm.c > @@ -48,6 +48,7 @@ static const struct meson_sm_chip gxbb_chip =3D { > CMD(SM_THERMAL_CALIB_READ, 0x82000047), > CMD(SM_A1_PWRC_SET, 0x82000093), > CMD(SM_A1_PWRC_GET, 0x82000095), > + CMD(SM_LOAD_VIDEO_FW, 0xb200000f), [Severity: High] This is a pre-existing issue, but does meson_sm_call() handle SMCCC errors correctly? Looking at meson_sm_call(), it unconditionally returns 0 after dispatching the command: drivers/firmware/meson/meson_sm.c:meson_sm_call() { ... lret =3D __meson_sm_call(cmd, arg0, arg1, arg2, arg3, arg4); if (ret) *ret =3D lret; return 0; } This masks SMCCC errors from callers that rely on its return value instead of checking the output parameter. For example, the power domain driver (drivers/pmdomain/amlogic/meson-secure-pwrc.c) passes a NULL pointer for the output parameter and relies on the return value of meson_sm_call() for error checking. This causes it to assume power operations always succeed, which could lead to a synchronous external abort (kernel panic) if hardware within a failed power domain is accessed. Similarly, meson_sm_get_thermal_calib() passes a pointer to receive calibration data, but if an error occurs, the SMC error code is directly written into this data, and the function incorrectly returns 0 (success): drivers/firmware/meson/meson_sm.c:meson_sm_get_thermal_calib() { ... return meson_sm_call(fw, SM_THERMAL_CALIB_READ, trim_info, tsensor_id, 0, 0, 0, 0); } Should meson_sm_call() propagate the error code in lret instead of always returning 0? > { /* sentinel */ }, > }, > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260831-b4-s4-vdec= -upstream-v8-0-830195b9bd91@amlogic.com?part=3D2