From: sashiko-bot@kernel.org
To: "Harald Freudenberger" <freude@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v5 3/3] s390/crypto: Fix use of mutex in atomic context
Date: Mon, 31 Aug 2026 09:10:26 +0000 [thread overview]
Message-ID: <20260831091026.E25871F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260831083735.3625-5-freude@linux.ibm.com>
> The AES CTR implementation used a mutex to lock one page of exclusive
> memory for fast CTR processing. Unfortunately a mutex is not save to
> use in atomic or interrupt context. So use a binary semaphore instead
> which is save to use in such environments.
>
> Furthermore rework the code to get rid of conditional locking. So
> restructure the AES CRT code by extracting the main loop into a
> separate function and just give in information about the (locked) page
> can be used or not (is not locked).
>
> Fixes: 7988fb2c03c8 ("crypto: s390/aes - convert to skcipher API")
> Suggested-by: Heiko Carstens <hca@linux.ibm.com>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831083735.3625-1-freude@linux.ibm.com?part=3
next prev parent reply other threads:[~2026-08-31 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 8:37 [PATCH v5 0/3] Fixes and rework for aes_s390 Harald Freudenberger
2026-08-31 8:37 ` Harald Freudenberger
2026-08-31 8:37 ` [PATCH v5 1/3] s390/crypto: Fix skcipher_walk return code handling in aes_s390 Harald Freudenberger
2026-08-31 8:49 ` sashiko-bot
2026-08-31 8:37 ` [PATCH v5 2/3] s390/crypto: Fix missing scrub of temp buffers with AES ctr and gcm algorithm Harald Freudenberger
2026-08-31 9:05 ` sashiko-bot
2026-08-31 8:37 ` [PATCH v5 3/3] s390/crypto: Fix use of mutex in atomic context Harald Freudenberger
2026-08-31 9:10 ` sashiko-bot [this message]
2026-09-03 19:33 ` [PATCH v5 0/3] Fixes and rework for aes_s390 Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831091026.E25871F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.