Re: [PATCH v4 1/3] arm64: dts: qcom: sm8450-hdk: Enable I2S for HDMI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The SoC I2S and MCLK pin configurations are improperly assigned to the external I2C HDMI bridge (`lt9611_codec`) node.
--

commit 1b83d3e4ad09bc9890002381b80f159a3782e66d
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8450-hdk: Enable I2S for HDMI

This commit adds the necessary device tree nodes to configure the I2S
interface to output audio via the DSI HDMI bridge. It updates the
external lt9611uxc bridge node and links the primary MI2S DAI.

> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 4ade28f40cae0..9b55d17869b49 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -665,7 +665,12 @@ lt9611_codec: hdmi-bridge@2b {
>  		vcc-supply = <&lt9611_3v3>;
>  
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&lt9611_irq_pin &lt9611_rst_pin>;
> +		pinctrl-0 = <&lt9611_irq_pin>,
> +			    <&lt9611_rst_pin>,
> +			    <&i2s0_default_state>,
> +			    <&audio_mclk0_default_state>;

[Severity: Medium]
Should the SoC's I2S and MCLK pin configurations be assigned to the external
lt9611uxc HDMI bridge node?

Since the lt9611uxc is an external I2C display bridge rather than the SoC's
LPASS I2S interface, assigning the audio pinmux states here means the pins
are permanently configured when the display bridge probes. This bypasses the
SoC's audio controller (like the q6apmbedai CPU DAI or sound node),
preventing it from managing its own pins' power states when audio is inactive.

Could these audio pinctrl states be moved to the sound card node or its
relevant sub-node instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-topic-sm8x50-next-hdk-i2s-v4-0-a224aa073f9d@linaro.org?part=1