From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9142E471261; Mon, 31 Aug 2026 13:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183312; cv=none; b=ijTwTEkXRqLEUvEKDNLpu8URCQXOT9+eu4e0EWP9wdXJXDUo+SvgJwIVJRPEVUxlRObSAPCr5ZR/VjV5rGSJRwuxl6TLbyVIx26lzjSHu36uCs7Sr6/8Bm5ewzv6dZf8NsmpdH2nB2JevbWav8pToHz16wFQII66ED5DFBoeqOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183312; c=relaxed/simple; bh=bxCI9Bw2mENQwrOJ2kSOCCWQ1uPpqfu5jigq8ZSxwHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lwwk7VJFNFZAt1mlpBdLJbyE+0XXDA5ch+C2yZZyX52we1UhI/Pohrq64f62rS7cSi362eABeKxaBi9q2+czNNCAtNJZPtQb8H2qHrqHJUWqYO2Ei/1NRPMP1EDg8lBY+GOkUJIWd8/7e8AzBe5kVkI06vwX+FkEHPvkOvtsDeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ToeQ/sqk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ToeQ/sqk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88B561F00A3F; Mon, 31 Aug 2026 13:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788183311; bh=7je4D7HCOA1A9JwOZ5zn8NV8msvnyViusw2JmHoGICg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ToeQ/sqkcMNUYEMXcqtf1ZSf3nqwry+4ru7zkUUvdcUhIGTSAK1nnotbFZw6Z3tlw S7vqxICM1ccSaM5ZGXe/2ugM34zYjnm6gYLu26oYg66Lnw55KwS1LIQtUF8y5yjkBm df9atEEFYBO0ixuBM5irNPFHQcbxz+/vQRe1pwKQyeyOZ+HH7L24kI+HNpG8IS8JIW TPbq769B4dN7eS9AdIlbcDNWJGOqBFqLxXw6DlDuIUEOHb1Vm69k4wNZll+jUoVL0L 1fmxoAiAXpbX+MC0EG5VJ7waR4C3M5M+IWcscuxQky3lwBS3a+zqzOS7lb65PC3P8y INYURhSx0b5Tg== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Osama Abdelkader , Paul Walmsley , Sasha Levin , palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.18-6.12] riscv: panic if IRQ handler stacks cannot be allocated Date: Mon, 31 Aug 2026 09:21:41 -0400 Message-ID: <20260831133314.4125787-73-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260831133314.4125787-1-sashal@kernel.org> References: <20260831133314.4125787-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.18.48 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Osama Abdelkader [ Upstream commit 2abd0dba562551d5c27f97ce560684f534c0cf3a ] init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack or scs_alloc return NULL, call panic() in this case. Signed-off-by: Osama Abdelkader Link: https://patch.msgid.link/20260404185522.21767-1-osama.abdelkader@gmail.com Signed-off-by: Paul Walmsley Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: The branch check finished: `2abd0dba56255` ("riscv: panic if IRQ handler stacks cannot be allocated") is on `master` and the `-next` integration branches, but not on the current `v6.18.44` stable tree. That matches the earlier **YES** backport recommendation — the fix is mainline-only and still needs to be cherry-picked into 6.18.y. arch/riscv/kernel/irq.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c index b6af20bc300f5..017d42e778be6 100644 --- a/arch/riscv/kernel/irq.c +++ b/arch/riscv/kernel/irq.c @@ -75,28 +75,34 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); #endif -static void init_irq_scs(void) +static void __init init_irq_scs(void) { int cpu; + void *s; if (!scs_is_enabled()) return; - for_each_possible_cpu(cpu) - per_cpu(irq_shadow_call_stack_ptr, cpu) = - scs_alloc(cpu_to_node(cpu)); + for_each_possible_cpu(cpu) { + s = scs_alloc(cpu_to_node(cpu)); + if (!s) + panic("Failed to allocate IRQ shadow call stack resources\n"); + per_cpu(irq_shadow_call_stack_ptr, cpu) = s; + } } DEFINE_PER_CPU(ulong *, irq_stack_ptr); #ifdef CONFIG_VMAP_STACK -static void init_irq_stacks(void) +static void __init init_irq_stacks(void) { int cpu; ulong *p; for_each_possible_cpu(cpu) { p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu)); + if (!p) + panic("Failed to allocate IRQ stack resources\n"); per_cpu(irq_stack_ptr, cpu) = p; } } @@ -104,7 +110,7 @@ static void init_irq_stacks(void) /* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */ DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack); -static void init_irq_stacks(void) +static void __init init_irq_stacks(void) { int cpu; @@ -129,8 +135,8 @@ void do_softirq_own_stack(void) #endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */ #else -static void init_irq_scs(void) {} -static void init_irq_stacks(void) {} +static void __init init_irq_scs(void) {} +static void __init init_irq_stacks(void) {} #endif /* CONFIG_IRQ_STACKS */ int arch_show_interrupts(struct seq_file *p, int prec) -- 2.53.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C04F6C624C6 for ; Mon, 31 Aug 2026 13:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uxf+glhaZ9RX7j1yQjv4RIhqNl8xs4BtpeN0hN7R+QM=; b=xvmJ2YWkYI+bSo uvU0gzEsN8gBZZA0ZJLL+8S0EBJFwEUiuiQCl+Y646kexM7dxeCwnYStU25PFRgUJTPpXLkjFBOde veExUx5+4p53Hfral0Zb86frrhYGtmHS+pTjuTkkt8QYymUHY3Jp1m/peaFf19ukjupunf6vauU+K QN8w0vDfXk0mFTvQHv+PwbCrxD3UhaN/sMD3JOktS8+EC06DvVi5snb4N6zSfCEH5Ab0aDKkOhi2y dUza45ZVSQ67UPENCbsXUnHj8OYJSvccGGk1ZqX8RnIPikL88rEckbNaClLBTUeEhZS/1DLN56efg JPeJLV+6K+TfdbyarPvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x12AL-00000009QwG-2cXB; Mon, 31 Aug 2026 13:35:13 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x12AK-00000009QvY-1S2n for linux-riscv@lists.infradead.org; Mon, 31 Aug 2026 13:35:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id C2EF360215; Mon, 31 Aug 2026 13:35:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88B561F00A3F; Mon, 31 Aug 2026 13:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788183311; bh=7je4D7HCOA1A9JwOZ5zn8NV8msvnyViusw2JmHoGICg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ToeQ/sqkcMNUYEMXcqtf1ZSf3nqwry+4ru7zkUUvdcUhIGTSAK1nnotbFZw6Z3tlw S7vqxICM1ccSaM5ZGXe/2ugM34zYjnm6gYLu26oYg66Lnw55KwS1LIQtUF8y5yjkBm df9atEEFYBO0ixuBM5irNPFHQcbxz+/vQRe1pwKQyeyOZ+HH7L24kI+HNpG8IS8JIW TPbq769B4dN7eS9AdIlbcDNWJGOqBFqLxXw6DlDuIUEOHb1Vm69k4wNZll+jUoVL0L 1fmxoAiAXpbX+MC0EG5VJ7waR4C3M5M+IWcscuxQky3lwBS3a+zqzOS7lb65PC3P8y INYURhSx0b5Tg== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Osama Abdelkader , Paul Walmsley , Sasha Levin , palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.18-6.12] riscv: panic if IRQ handler stacks cannot be allocated Date: Mon, 31 Aug 2026 09:21:41 -0400 Message-ID: <20260831133314.4125787-73-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260831133314.4125787-1-sashal@kernel.org> References: <20260831133314.4125787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.18.48 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org RnJvbTogT3NhbWEgQWJkZWxrYWRlciA8b3NhbWEuYWJkZWxrYWRlckBnbWFpbC5jb20+CgpbIFVw c3RyZWFtIGNvbW1pdCAyYWJkMGRiYTU2MjU1MWQ1YzI3Zjk3Y2U1NjA2ODRmNTM0YzBjZjNhIF0K CmluaXRfaXJxX3N0YWNrcygpIGFuZCBpbml0X2lycV9zY3MoKSBtYXkgZmFpbCB3aGVuIGFyY2hf YWxsb2Nfdm1hcF9zdGFjawpvciBzY3NfYWxsb2MgcmV0dXJuIE5VTEwsIGNhbGwgcGFuaWMoKSBp biB0aGlzIGNhc2UuCgpTaWduZWQtb2ZmLWJ5OiBPc2FtYSBBYmRlbGthZGVyIDxvc2FtYS5hYmRl bGthZGVyQGdtYWlsLmNvbT4KTGluazogaHR0cHM6Ly9wYXRjaC5tc2dpZC5saW5rLzIwMjYwNDA0 MTg1NTIyLjIxNzY3LTEtb3NhbWEuYWJkZWxrYWRlckBnbWFpbC5jb20KU2lnbmVkLW9mZi1ieTog UGF1bCBXYWxtc2xleSA8cGp3QGtlcm5lbC5vcmc+ClNpZ25lZC1vZmYtYnk6IFNhc2hhIExldmlu IDxzYXNoYWxAa2VybmVsLm9yZz4KLS0tCgpMTE0gR2VuZXJhdGVkIGV4cGxhbmF0aW9ucywgbWF5 IGJlIGNvbXBsZXRlbHkgYm9ndXM6CgpUaGUgYnJhbmNoIGNoZWNrIGZpbmlzaGVkOiBgMmFiZDBk YmE1NjI1NWAgKCJyaXNjdjogcGFuaWMgaWYgSVJRIGhhbmRsZXIKc3RhY2tzIGNhbm5vdCBiZSBh bGxvY2F0ZWQiKSBpcyBvbiBgbWFzdGVyYCBhbmQgdGhlIGAtbmV4dGAgaW50ZWdyYXRpb24KYnJh bmNoZXMsIGJ1dCBub3Qgb24gdGhlIGN1cnJlbnQgYHY2LjE4LjQ0YCBzdGFibGUgdHJlZS4gVGhh dCBtYXRjaGVzCnRoZSBlYXJsaWVyICoqWUVTKiogYmFja3BvcnQgcmVjb21tZW5kYXRpb24g4oCU IHRoZSBmaXggaXMgbWFpbmxpbmUtb25seQphbmQgc3RpbGwgbmVlZHMgdG8gYmUgY2hlcnJ5LXBp Y2tlZCBpbnRvIDYuMTgueS4KCiBhcmNoL3Jpc2N2L2tlcm5lbC9pcnEuYyB8IDIyICsrKysrKysr KysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3Yva2VybmVsL2lycS5jIGIvYXJjaC9yaXNj di9rZXJuZWwvaXJxLmMKaW5kZXggYjZhZjIwYmMzMDBmNS4uMDE3ZDQyZTc3OGJlNiAxMDA2NDQK LS0tIGEvYXJjaC9yaXNjdi9rZXJuZWwvaXJxLmMKKysrIGIvYXJjaC9yaXNjdi9rZXJuZWwvaXJx LmMKQEAgLTc1LDI4ICs3NSwzNCBAQCBERUNMQVJFX1BFUl9DUFUodWxvbmcgKiwgaXJxX3NoYWRv d19jYWxsX3N0YWNrX3B0cik7CiBERUZJTkVfUEVSX0NQVSh1bG9uZyAqLCBpcnFfc2hhZG93X2Nh bGxfc3RhY2tfcHRyKTsKICNlbmRpZgogCi1zdGF0aWMgdm9pZCBpbml0X2lycV9zY3Modm9pZCkK K3N0YXRpYyB2b2lkIF9faW5pdCBpbml0X2lycV9zY3Modm9pZCkKIHsKIAlpbnQgY3B1OworCXZv aWQgKnM7CiAKIAlpZiAoIXNjc19pc19lbmFibGVkKCkpCiAJCXJldHVybjsKIAotCWZvcl9lYWNo X3Bvc3NpYmxlX2NwdShjcHUpCi0JCXBlcl9jcHUoaXJxX3NoYWRvd19jYWxsX3N0YWNrX3B0ciwg Y3B1KSA9Ci0JCQlzY3NfYWxsb2MoY3B1X3RvX25vZGUoY3B1KSk7CisJZm9yX2VhY2hfcG9zc2li bGVfY3B1KGNwdSkgeworCQlzID0gc2NzX2FsbG9jKGNwdV90b19ub2RlKGNwdSkpOworCQlpZiAo IXMpCisJCQlwYW5pYygiRmFpbGVkIHRvIGFsbG9jYXRlIElSUSBzaGFkb3cgY2FsbCBzdGFjayBy ZXNvdXJjZXNcbiIpOworCQlwZXJfY3B1KGlycV9zaGFkb3dfY2FsbF9zdGFja19wdHIsIGNwdSkg PSBzOworCX0KIH0KIAogREVGSU5FX1BFUl9DUFUodWxvbmcgKiwgaXJxX3N0YWNrX3B0cik7CiAK ICNpZmRlZiBDT05GSUdfVk1BUF9TVEFDSwotc3RhdGljIHZvaWQgaW5pdF9pcnFfc3RhY2tzKHZv aWQpCitzdGF0aWMgdm9pZCBfX2luaXQgaW5pdF9pcnFfc3RhY2tzKHZvaWQpCiB7CiAJaW50IGNw dTsKIAl1bG9uZyAqcDsKIAogCWZvcl9lYWNoX3Bvc3NpYmxlX2NwdShjcHUpIHsKIAkJcCA9IGFy Y2hfYWxsb2Nfdm1hcF9zdGFjayhJUlFfU1RBQ0tfU0laRSwgY3B1X3RvX25vZGUoY3B1KSk7CisJ CWlmICghcCkKKwkJCXBhbmljKCJGYWlsZWQgdG8gYWxsb2NhdGUgSVJRIHN0YWNrIHJlc291cmNl c1xuIik7CiAJCXBlcl9jcHUoaXJxX3N0YWNrX3B0ciwgY3B1KSA9IHA7CiAJfQogfQpAQCAtMTA0 LDcgKzExMCw3IEBAIHN0YXRpYyB2b2lkIGluaXRfaXJxX3N0YWNrcyh2b2lkKQogLyogaXJxIHN0 YWNrIG9ubHkgbmVlZHMgdG8gYmUgMTYgYnl0ZSBhbGlnbmVkIC0gbm90IElSUV9TVEFDS19TSVpF IGFsaWduZWQuICovCiBERUZJTkVfUEVSX0NQVV9BTElHTkVEKHVsb25nIFtJUlFfU1RBQ0tfU0la RS9zaXplb2YodWxvbmcpXSwgaXJxX3N0YWNrKTsKIAotc3RhdGljIHZvaWQgaW5pdF9pcnFfc3Rh Y2tzKHZvaWQpCitzdGF0aWMgdm9pZCBfX2luaXQgaW5pdF9pcnFfc3RhY2tzKHZvaWQpCiB7CiAJ aW50IGNwdTsKIApAQCAtMTI5LDggKzEzNSw4IEBAIHZvaWQgZG9fc29mdGlycV9vd25fc3RhY2so dm9pZCkKICNlbmRpZiAvKiBDT05GSUdfU09GVElSUV9PTl9PV05fU1RBQ0sgKi8KIAogI2Vsc2UK LXN0YXRpYyB2b2lkIGluaXRfaXJxX3Njcyh2b2lkKSB7fQotc3RhdGljIHZvaWQgaW5pdF9pcnFf c3RhY2tzKHZvaWQpIHt9CitzdGF0aWMgdm9pZCBfX2luaXQgaW5pdF9pcnFfc2NzKHZvaWQpIHt9 CitzdGF0aWMgdm9pZCBfX2luaXQgaW5pdF9pcnFfc3RhY2tzKHZvaWQpIHt9CiAjZW5kaWYgLyog Q09ORklHX0lSUV9TVEFDS1MgKi8KIAogaW50IGFyY2hfc2hvd19pbnRlcnJ1cHRzKHN0cnVjdCBz ZXFfZmlsZSAqcCwgaW50IHByZWMpCi0tIAoyLjUzLjAKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgt cmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==