Re: [PATCH] xfs: release alleged child inode on metapath unlink error

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 31, 2026 at 12:11:57PM +0530, Anuj Gupta wrote:
> If xchk_metapath_ilock_parent_and_child() fails after xchk_iget()
> succeeds, release the inode reference before returning.
> 
> Fixes: 0d2c636e489c ("xfs: repair metadata directory file path connectivity")

I have a patch just like this one in my branch so

Cc: <stable@vger.kernel.org> # v6.13
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
> ---
>  fs/xfs/scrub/metapath.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/scrub/metapath.c b/fs/xfs/scrub/metapath.c
> index ff1ff762b300..79fd69d2de68 100644
> --- a/fs/xfs/scrub/metapath.c
> +++ b/fs/xfs/scrub/metapath.c
> @@ -550,6 +550,8 @@ xrep_metapath_try_unlink(
>  	}
>  	if (error) {
>  		xchk_trans_cancel(sc);
> +		if (ip)
> +			xchk_irele(sc, ip);
>  		return error;
>  	}
>  
> -- 
> 2.25.1
> 
>