All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Iván Ezequiel Rodriguez" <ivanrwcm25@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Iván Ezequiel Rodriguez" <ivanrwcm25@gmail.com>
Subject: [PATCH v1 1/2] block: brd: destroy xa on allocation failure
Date: Mon, 31 Aug 2026 12:20:43 -0300	[thread overview]
Message-ID: <20260831152044.166353-2-ivanrwcm25@gmail.com> (raw)
In-Reply-To: <20260831152044.166353-1-ivanrwcm25@gmail.com>

xa_init() runs before blk_alloc_disk(); on error the path called
brd_free_device() without xa_destroy(), leaking the xarray state.

Signed-off-by: Iván Ezequiel Rodriguez <ivanrwcm25@gmail.com>
---
 drivers/block/brd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 00cc8122068f..c18262295c39 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -346,6 +346,7 @@ static int brd_alloc(int i)
 out_cleanup_disk:
 	put_disk(disk);
 out_free_dev:
+	xa_destroy(&brd->brd_pages);
 	brd_free_device(brd);
 	return err;
 }
-- 
2.43.0


  reply	other threads:[~2026-08-31 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 15:20 [PATCH v1 0/2] block: brd/loop error-path cleanup Iván Ezequiel Rodriguez
2026-08-31 15:20 ` Iván Ezequiel Rodriguez [this message]
2026-08-31 15:20 ` [PATCH v1 2/2] block: loop: restore state on loop_configure() error Iván Ezequiel Rodriguez
2026-09-01  6:59 ` [syzbot ci] Re: block: brd/loop error-path cleanup syzbot ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831152044.166353-2-ivanrwcm25@gmail.com \
    --to=ivanrwcm25@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.