From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, sdf@fomichev.me, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
horms@kernel.org, andrew+netdev@lunn.ch, bpf@vger.kernel.org,
netdev@vger.kernel.org,
syzbot+f16c1b285c9f63994eec@syzkaller.appspotmail.com
Subject: Re: [PATCH net] xsk: set network header on skb at generic transmit
Date: Mon, 31 Aug 2026 17:02:41 -0700 [thread overview]
Message-ID: <20260831170241.42be3376@kernel.org> (raw)
In-Reply-To: <20260826012052.51028-1-kerneljasonxing@gmail.com>
On Wed, 26 Aug 2026 09:20:52 +0800 Jason Xing wrote:
> Fix this by calling skb_reset_network_header() in the common path to
> cover both the copy and the zerocopy cases, so that network_header
> points at skb->data and skb_network_offset() returns 0.
But you're setting it to start of the frame so most likely L2.
AF_PACKET seems to probe to find the true network header.
IDK. At the very least the commit message should be explaining
why the fix is right instead of the slop explaining the path
that triggers the crash.
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-01 0:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 1:20 [PATCH net] xsk: set network header on skb at generic transmit Jason Xing
2026-09-01 0:02 ` Jakub Kicinski [this message]
2026-09-01 7:51 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831170241.42be3376@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=syzbot+f16c1b285c9f63994eec@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.