All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Kanchan Joshi <joshi.k@samsung.com>,
	Anuj Gupta <anuj20.g@samsung.com>,
	John Garry <john.g.garry@oracle.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/6] common: add a _sysfs_block_integrity_path helper
Date: Mon, 31 Aug 2026 10:03:38 -0700	[thread overview]
Message-ID: <20260831170338.GA839663@frogsfrogsfrogs> (raw)
In-Reply-To: <20260831064557.2577241-4-hch@lst.de>

On Mon, Aug 31, 2026 at 09:45:47AM +0300, Christoph Hellwig wrote:
> Add a helper function to find the sysfs integrity directory for a given
> block device.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good now,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  common/rc | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 2fa7ddebd8fd..5e709dd79993 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -5264,6 +5264,21 @@ _sysfs_queue_path()
>  	return 1
>  }
>  
> +# Get the sysfs block device integrity/ path for a block device, handling
> +# partitions correctly.
> +_sysfs_block_integrity_path()
> +{
> +	local disk=$(_bdev_disk_name "$1")
> +	local integrity_path="/sys/block/$disk/integrity"
> +
> +	if [ -e "$integrity_path" ]; then
> +		echo "$integrity_path"
> +		return 0
> +	fi
> +
> +	return 1
> +}
> +
>  # Get the minimum block size of a file.  Usually this is the
>  # minimum fs block size, but some filesystems (ocfs2) do block
>  # mappings in larger units.
> -- 
> 2.53.0
> 
> 

  reply	other threads:[~2026-08-31 17:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  6:45 add tests for file system on devices using protection information v3 Christoph Hellwig
2026-08-31  6:45 ` [PATCH 1/6] common/scsi_debug: don't slow down I/O Christoph Hellwig
2026-08-31  6:45 ` [PATCH 2/6] common: factor out a _bdev_disk_name helper Christoph Hellwig
2026-08-31 17:03   ` Darrick J. Wong
2026-08-31  6:45 ` [PATCH 3/6] common: add a _sysfs_block_integrity_path helper Christoph Hellwig
2026-08-31 17:03   ` Darrick J. Wong [this message]
2026-08-31  6:45 ` [PATCH 4/6] add a "pi" group Christoph Hellwig
2026-08-31  6:45 ` [PATCH 5/6] generic: test I/O on devices with T10 protection information Christoph Hellwig
2026-09-01  6:38   ` Kanchan Joshi
2026-09-07  5:48     ` Christoph Hellwig
2026-09-03  6:01   ` Anuj Gupta/Anuj Gupta
2026-08-31  6:45 ` [PATCH 6/6] generic: test corruption detection using " Christoph Hellwig
2026-09-03  6:00   ` Anuj Gupta/Anuj Gupta
2026-09-07  5:49     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2026-09-07  7:58 add tests for file system on devices using protection information v4 Christoph Hellwig
2026-09-07  7:58 ` [PATCH 3/6] common: add a _sysfs_block_integrity_path helper Christoph Hellwig
2026-09-08 14:32   ` Kanchan Joshi
2026-09-11  7:08 add tests for file system on devices using protection information v5 Christoph Hellwig
2026-09-11  7:08 ` [PATCH 3/6] common: add a _sysfs_block_integrity_path helper Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831170338.GA839663@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=anuj20.g@samsung.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=joshi.k@samsung.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.