From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D06146A5F8 for ; Mon, 31 Aug 2026 17:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788196643; cv=none; b=Y9n+tOaDv1KFzMGJx4tenqwtwXoIyUwXOdke2EEnjWaoAP5P0LVUXe8zctcvRPC1jpe0PUKvDEIhsmKrLWhWdtVwNHiwu8y1m+UJBRYP7lOnHy3nIA9eTS5QyVThpZ3Sug96lfvapduP0Cu70Ml8ZrO5NGuWRQpGlGABkMBSnic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788196643; c=relaxed/simple; bh=CfzYIXSjTWFdktRjHjPWG1ozB0am17J/QlOH4XNcMGM=; h=Date:To:From:Subject:Message-Id; b=qCTYi1iGkmZsOvZFIULvS0weo9M4SkkCLQJ0rnuOUgGa8P6jB0J081iMbvEeyI2v2AMyIj8Oo29aIiYaIzbNERGd+1aWkr0SduravtGnKrsEQ2eEmFQLEBQRugqXKQrPkBr2Z3GyBLuffHW7NRm7uTbDvSfYcbfHRzbcKhGJslQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ic/VND6/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ic/VND6/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E89181F000E9; Mon, 31 Aug 2026 17:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1788196642; bh=xUvcbVDWZjmAzlmQeRYjWmSFNGzxqbgigeJfDcx5zUc=; h=Date:To:From:Subject; b=ic/VND6/qSbjll8GTSUcQgjrYczgjyRsB/RwqU7REwBYzN72sgEAEwWtoEjKee+Wn mnXWQ7Jxb0yYe7RSLTw9eFCUiBWIE8XyDyAv1CShPML212qje13CkS+j0Yb5II5rXN Nvn5/Qt0FRYLAh7l9bzLnllsxIZEHH2VN4Of+bP8= Date: Mon, 31 Aug 2026 10:17:21 -0700 To: mm-commits@vger.kernel.org,vbabka@kernel.org,surenb@google.com,rppt@kernel.org,mhocko@suse.com,liam@infradead.org,david@kernel.org,ljs@kernel.org,akpm@linux-foundation.org From: Andrew Morton Subject: + mm-vmpressure-remove-window-size-todo.patch added to mm-new branch Message-Id: <20260831171721.E89181F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch titled Subject: mm/vmpressure: remove window size TODO has been added to the -mm mm-new branch. Its filename is mm-vmpressure-remove-window-size-todo.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vmpressure-remove-window-size-todo.patch This patch will later appear in the mm-new branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Note, mm-new is a provisional staging ground for work-in-progress patches, and acceptance into mm-new is a notification for others take notice and to finish up reviews. Please do not hesitate to respond to review feedback and post updated versions to replace or incrementally fixup patches in mm-new. The mm-new branch of mm.git is not included in linux-next If a few days of testing in mm-new is successful, the patch will me moved into mm.git's mm-unstable branch, which is included in linux-next Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via various branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there most days ------------------------------------------------------ From: "Lorenzo Stoakes (ARM)" Subject: mm/vmpressure: remove window size TODO Date: Mon, 31 Aug 2026 14:42:11 +0100 There has been a steady stream of patches that have been submitted by newcomers to core mm 'fixing' this TODO, with all but the original having very likely been generated by LLMs. It appears that TODOs to LLMs are like red rags to a bull. In addition, TODOs in code often bitrot and are distracting - those who understand the code know what could be improved in future. Therefore remove the TODO. The work required to actually fix this TODO requires somebody who both has understanding of the code and significant real-world data to back their changes. Such a person doesn't require a TODO prompt to implement this change, so nothing of value is being lost here. Link: https://lore.kernel.org/all/20260831130316.448-1-tahasezer.is@gmail.com/ Link: https://lore.kernel.org/linux-mm/20260724054305.516126-1-cui.tao@linux.dev/ Link: https://lore.kernel.org/linux-mm/20260715143646.15828-1-gaikwad.dcg@gmail.com/ Link: https://lore.kernel.org/all/20260227221555.29969-1-mcq@disroot.org/ Link: https://lore.kernel.org/20260831-remove-vmpressure-todo-v1-1-498515e59cdf@kernel.org Signed-off-by: Lorenzo Stoakes (ARM) Cc: David Hildenbrand Cc: Liam R. Howlett Cc: Michal Hocko Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- mm/vmpressure.c | 3 --- 1 file changed, 3 deletions(-) --- a/mm/vmpressure.c~mm-vmpressure-remove-window-size-todo +++ a/mm/vmpressure.c @@ -30,9 +30,6 @@ * * As the vmscan reclaimer logic works with chunks which are multiple of * SWAP_CLUSTER_MAX, it makes sense to use it for the window size as well. - * - * TODO: Make the window size depend on machine size, as we do for vmstat - * thresholds. Currently we set it to 512 pages (2MB for 4KB pages). */ const unsigned long vmpressure_win = SWAP_CLUSTER_MAX * 16; _ Patches currently in -mm which might be from ljs@kernel.org are mm-mremap-reset-unfaulted-vma-page-offset-for-mremap_dontunmap.patch mm-secretmem-properly-account-locked-pages.patch mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings.patch mm-mremap-account-mm-locked_vm-correctly-for-mremap_dontunmap.patch mm-vmpressure-remove-window-size-todo.patch