From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] dtc: dt-check-style: Add test for node and property name styles
Date: Mon, 31 Aug 2026 12:58:58 -0500 [thread overview]
Message-ID: <20260831175858.GA880726-robh@kernel.org> (raw)
In-Reply-To: <425f93a7-3574-4681-b5e6-9bef45ed39a2@kernel.org>
On Sun, Aug 30, 2026 at 10:57:23PM +0200, Krzysztof Kozlowski wrote:
> On 30/08/2026 21:59, Rob Herring wrote:
> > On Sat, Aug 29, 2026 at 09:53:20PM +0200, Krzysztof Kozlowski wrote:
> >> Common style violation is usage of underscores in node or property
> >> names, so add rules for following recommended names. There is plenty of
> >> legacy approach, so add the rules only for 'strict' mode of checking.
> >
> > We already have this in dtc, do we need it here too?
>
> Not sure really. DTC has it in W=2, so initially I thought no one ever
> looks there, but duplicating maybe is not a good idea. I don't mind
> skipping this, next patches in this set should still apply cleanly.
Well, I guess this is a bit more exhaustive in what it allows.
Series applied.
Rob
next prev parent reply other threads:[~2026-08-31 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 19:53 [PATCH 0/6] dtc: dt-check-style: Cleanup plus new checks Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 1/6] dtc: dt-check-style: Sort rule directory by name Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 2/6] dtc: dt-check-style: Sort rule functions " Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 3/6] dtc: dt-check-style: Process property names with a question mark Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 4/6] dtc: dt-check-style: Add test for node and property name styles Krzysztof Kozlowski
2026-08-30 19:59 ` Rob Herring
2026-08-30 20:57 ` Krzysztof Kozlowski
2026-08-31 17:58 ` Rob Herring [this message]
2026-08-29 19:53 ` [PATCH 5/6] dtc: dt-check-style: Check for indentation also in continued lines of DTS Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 6/6] dtc: dt-check-style: Check for indentation also in continued lines of bindings example Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831175858.GA880726-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.