Re: [PATCH v4 2/3] mm/damon/sysfs: support hugepage_mem_bp quota goal metric

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new `hugepage_mem_bp` metric is missing from the sysfs selftests.
--

commit a2c5ad81dadcc820e74efd9d73c1f576bbe76457
Author: Asier Gutierrez <gutierrez.asier@huawei-partners.com>

mm/damon/sysfs: support hugepage_mem_bp quota goal metric

This commit introduces the new DAMOS_QUOTA_HUGEPAGE_MEM_BP autotune policy
metric. It also exposes this metric to userspace through the sysfs-schemes
interface by adding "hugepage_mem_bp" to the list of recognized metrics.

> diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
> index 32f495a96b17a..d9b81d7b5910e 100644
> --- a/mm/damon/sysfs-schemes.c
> +++ b/mm/damon/sysfs-schemes.c

[ ... ]

> @@ -1269,6 +1269,10 @@ struct damos_sysfs_qgoal_metric_name damos_sysfs_qgoal_metric_names[] = {
>  		.metric = DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP,
>  		.name = "node_eligible_mem_bp",
>  	},
> +	{
> +		.metric = DAMOS_QUOTA_HUGEPAGE_MEM_BP,
> +		.name = "hugepage_mem_bp",
> +	},

[Severity: Medium]
Should the new hugepage_mem_bp metric be added to the DAMON sysfs kselftest?

Looking at tools/testing/selftests/damon/sysfs.sh in test_goal(), it explicitly
validates all supported metric strings by writing them to the sysfs node:

    ensure_write_succ "$fpath" "node_eligible_mem_bp" "valid input"
    ensure_write_fail "$fpath" "foo" "invalid input"

Without adding hugepage_mem_bp to this selftest script, the new sysfs metric
is left without automated test coverage.

>  };
>  
>  static ssize_t target_metric_show(struct kobject *kobj,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831144732.80910-1-sj@kernel.org?part=2