All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Burkov <boris@bur.io>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: qgroup: mark qgroup inconsistent for more
Date: Mon, 31 Aug 2026 14:54:37 -0700	[thread overview]
Message-ID: <20260831215437.GC325502@zen.localdomain> (raw)
In-Reply-To: <cover.1787812966.git.wqu@suse.com>

On Thu, Aug 27, 2026 at 04:25:28PM +0930, Qu Wenruo wrote:
> Commit 011b46c30476 ("btrfs: skip subtree scan if it's too high to avoid
> low stall in btrfs_commit_transaction()") covers the most common case
> that can cause a long qgroup stall, where a large subtree is rescanned
> when dropping a snapshot.
> 
> But there are more corner cases for the same long qgroup stall:
> 
> - A qgroup rescan is queued immediately after marking inconsistent
>   The new rescan will immediately revert the NO_ACCOUNTING flag, thus
>   still results long qgroup stalls.
> 
> - A subvolume with no shared subtree
>   This can still queue a lot of workload into the current transaction.
> 
> This series covers both less-common cases.

Reviewed-by: Boris Burkov <boris@bur.io>

Thanks,
Boris

> 
> Qu Wenruo (2):
>   btrfs: reject new qgroup rescan during subvolume dropping
>   btrfs: avoid long stall when dropping a non-shared large subvolume
> 
>  fs/btrfs/disk-io.c     |  4 ++++
>  fs/btrfs/extent-tree.c | 11 +++++++++++
>  fs/btrfs/qgroup.c      | 29 ++++++++++++++++++++++++++++-
>  fs/btrfs/qgroup.h      | 15 +++++++++++++++
>  4 files changed, 58 insertions(+), 1 deletion(-)
> 
> -- 
> 2.55.0
> 

      parent reply	other threads:[~2026-08-31 21:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27  6:55 [PATCH 0/2] btrfs: qgroup: mark qgroup inconsistent for more Qu Wenruo
2026-08-27  6:55 ` [PATCH 1/2] btrfs: reject new qgroup rescan during subvolume dropping Qu Wenruo
2026-08-27  6:55 ` [PATCH 2/2] btrfs: avoid long stall when dropping a non-shared large subvolume Qu Wenruo
2026-08-31 21:54 ` Boris Burkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831215437.GC325502@zen.localdomain \
    --to=boris@bur.io \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.