Re: [PATCH 08/13] dt-bindings: mfd: ab8500: Add regulators

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]

On Mon, Aug 31, 2026 at 10:18:09PM +0200, Linus Walleij wrote:
> On Mon, Aug 31, 2026 at 6:18 PM Conor Dooley <conor@kernel.org> wrote:
> 
> 
> > > +            ab8500_buck_smps1:
> > > +            ab8500_buck_smps2:
> > > +            ab8500_buck_smps3:
> >
> > How do these differ from
> >   regulator-external:
> >       ab8500_ext1:
> >         description: The voltage for the VSMPS1 external regulator
> >       ab8500_ext2:
> >         description: The voltage for the VSMPS2 external regulator
> >       ab8500_ext3:
> >         description: The voltage for the VSMPS3 external regulator
> 
> Exactly in the way they say, the former are internal, the regulators
> exist in the AB8500/AB8505 silicon. The latter are external,
> they are just control channels for regulators outside of the
> AB8500/AB8505.
> 
> The three "external regulators" are control channels going out
> of the AB8500/AB8505 to control secondary silicon outside
> of the AB8500/AB8505.
> 
> It is also clearly seen in the Linux driver which use different
> registers.
> 
> The similar name "VSMPS1/2/3" is incidental.

Right, I see.

> 
> SMPS == Switched Mode Power Supply.
> 
> (Customers didn't much use the external regulators. They
> usually implemeted GPIO-controlled regulators on the side
> instead.)
> 
> If you want I can add some verbiage explaining that they are
> not the same despite the name is similar.

If you think it'll help people that actually have the device, yes.

> 
> > > +            ab8500_buck_arm:
> >
> > realistically, all of these should have -s instead of _s.
> 
> Can you elaborate, I have a hard time understanding that
> terse comment :D

Node-names and properties are expected to have -s instead of _s in them.
so ab8500-buck-arm etc

Although, all your existing ones have _s, so there's conflicting
feelings with my OCD. Do w/e you like, for that reason.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]