Re: [PATCH v3 14/21] lib: rspdm: Support SPDM get_version

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `kernel::sync` import violates the kernel vertical import style guidelines.
--

commit 2c0be141f2603418ed69b0153c6ee75043525d1f
Author: Alistair Francis <alistair@alistair23.me>

lib: rspdm: Support SPDM get_version

Support the GET_VERSION SPDM command.

[ ... ]

> diff --git a/lib/rspdm/lib.rs b/lib/rspdm/lib.rs
> index 1883579b817aa..58d86ea06fd93 100644
> --- a/lib/rspdm/lib.rs
> +++ b/lib/rspdm/lib.rs
> @@ -18,8 +18,10 @@
>      c_int,
>      c_void, //
>  };
> +use core::pin::Pin;
>  use core::ptr;
>  use kernel::prelude::*;
> +use kernel::sync::{new_mutex, Mutex};

[Severity: Low]
Should the kernel::sync import in lib/rspdm/lib.rs be reformatted to follow
the kernel vertical import style guidelines rather than grouping multiple items
on a single line?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901010347.2614656-1-alistair.francis@wdc.com?part=14