All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: fs/proc/base.c:3279:4-39: opportunity for str_yes_no(mm_flags_test ( MMF_VM_MERGE_ANY , mm ))
Date: Tue, 01 Sep 2026 02:10:04 +0800	[thread overview]
Message-ID: <202609010248.vFbMtF1I-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: "Liam R. Howlett" <Liam.Howlett@oracle.com>
CC: "Mike Rapoport (Microsoft)" <rppt@kernel.org>

Hi Lorenzo,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   cee9395acd8043be0644b25c34bfa86623f2b935
commit: d14d3f535e13ff0661b9a74133a8d6b9f9950712 mm: convert remaining users to mm_flags_*() accessors
date:   12 months ago
:::::: branch date: 21 hours ago
:::::: commit date: 12 months ago
config: arc-randconfig-r053-20260831 (https://download.01.org/0day-ci/archive/20260901/202609010248.vFbMtF1I-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 9.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: d14d3f535e13 ("mm: convert remaining users to mm_flags_*() accessors")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202609010248.vFbMtF1I-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
   fs/proc/base.c:3286:4-29: opportunity for str_yes_no(ksm_process_mergeable ( mm ))
>> fs/proc/base.c:3279:4-39: opportunity for str_yes_no(mm_flags_test ( MMF_VM_MERGE_ANY , mm ))

vim +3279 fs/proc/base.c

7c23b330011690 Josh Poimboeuf  2017-02-13  3251  
7609385337a4fe xu xin          2022-04-28  3252  #ifdef CONFIG_KSM
7609385337a4fe xu xin          2022-04-28  3253  static int proc_pid_ksm_merging_pages(struct seq_file *m, struct pid_namespace *ns,
7609385337a4fe xu xin          2022-04-28  3254  				struct pid *pid, struct task_struct *task)
7609385337a4fe xu xin          2022-04-28  3255  {
7609385337a4fe xu xin          2022-04-28  3256  	struct mm_struct *mm;
7609385337a4fe xu xin          2022-04-28  3257  
7609385337a4fe xu xin          2022-04-28  3258  	mm = get_task_mm(task);
7609385337a4fe xu xin          2022-04-28  3259  	if (mm) {
7609385337a4fe xu xin          2022-04-28  3260  		seq_printf(m, "%lu\n", mm->ksm_merging_pages);
7609385337a4fe xu xin          2022-04-28  3261  		mmput(mm);
7609385337a4fe xu xin          2022-04-28  3262  	}
7609385337a4fe xu xin          2022-04-28  3263  
7609385337a4fe xu xin          2022-04-28  3264  	return 0;
7609385337a4fe xu xin          2022-04-28  3265  }
cb4df4cae4f2bd xu xin          2022-08-30  3266  static int proc_pid_ksm_stat(struct seq_file *m, struct pid_namespace *ns,
cb4df4cae4f2bd xu xin          2022-08-30  3267  				struct pid *pid, struct task_struct *task)
cb4df4cae4f2bd xu xin          2022-08-30  3268  {
cb4df4cae4f2bd xu xin          2022-08-30  3269  	struct mm_struct *mm;
3ab76c767bc783 xu xin          2025-01-10  3270  	int ret = 0;
cb4df4cae4f2bd xu xin          2022-08-30  3271  
cb4df4cae4f2bd xu xin          2022-08-30  3272  	mm = get_task_mm(task);
cb4df4cae4f2bd xu xin          2022-08-30  3273  	if (mm) {
cb4df4cae4f2bd xu xin          2022-08-30  3274  		seq_printf(m, "ksm_rmap_items %lu\n", mm->ksm_rmap_items);
c2dc78b86e0821 Chengming Zhou  2024-05-28  3275  		seq_printf(m, "ksm_zero_pages %ld\n", mm_ksm_zero_pages(mm));
d21077fbc2fc98 Stefan Roesch   2023-04-17  3276  		seq_printf(m, "ksm_merging_pages %lu\n", mm->ksm_merging_pages);
d21077fbc2fc98 Stefan Roesch   2023-04-17  3277  		seq_printf(m, "ksm_process_profit %ld\n", ksm_process_profit(mm));
3ab76c767bc783 xu xin          2025-01-10  3278  		seq_printf(m, "ksm_merge_any: %s\n",
d14d3f535e13ff Lorenzo Stoakes 2025-08-12 @3279  				mm_flags_test(MMF_VM_MERGE_ANY, mm) ? "yes" : "no");
3ab76c767bc783 xu xin          2025-01-10  3280  		ret = mmap_read_lock_killable(mm);
3ab76c767bc783 xu xin          2025-01-10  3281  		if (ret) {
3ab76c767bc783 xu xin          2025-01-10  3282  			mmput(mm);
3ab76c767bc783 xu xin          2025-01-10  3283  			return ret;
3ab76c767bc783 xu xin          2025-01-10  3284  		}
3ab76c767bc783 xu xin          2025-01-10  3285  		seq_printf(m, "ksm_mergeable: %s\n",
3ab76c767bc783 xu xin          2025-01-10  3286  				ksm_process_mergeable(mm) ? "yes" : "no");
3ab76c767bc783 xu xin          2025-01-10  3287  		mmap_read_unlock(mm);
cb4df4cae4f2bd xu xin          2022-08-30  3288  		mmput(mm);
cb4df4cae4f2bd xu xin          2022-08-30  3289  	}
cb4df4cae4f2bd xu xin          2022-08-30  3290  
cb4df4cae4f2bd xu xin          2022-08-30  3291  	return 0;
cb4df4cae4f2bd xu xin          2022-08-30  3292  }
7609385337a4fe xu xin          2022-04-28  3293  #endif /* CONFIG_KSM */
7609385337a4fe xu xin          2022-04-28  3294  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2026-08-31 18:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 18:10 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-04  5:34 fs/proc/base.c:3279:4-39: opportunity for str_yes_no(mm_flags_test ( MMF_VM_MERGE_ANY , mm )) kernel test robot
2025-10-23  7:29 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609010248.vFbMtF1I-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.