From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199BAC61DFD for ; Tue, 1 Sep 2026 03:10:16 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B87AD40E6E; Tue, 1 Sep 2026 05:10:11 +0200 (CEST) Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) by mails.dpdk.org (Postfix) with ESMTP id 41F4340E48; Tue, 1 Sep 2026 05:10:10 +0200 (CEST) Received: from localhost.localdomain (unknown [118.112.177.181]) by APP-05 (Coremail) with SMTP id zQCowAAHdT8OQpZqSf8hBw--.61282S2; Tue, 01 Sep 2026 11:10:06 +0800 (CST) From: liujie5@linkdatatechnology.com To: stephen@networkplumber.org Cc: dev@dpdk.org, Jie Liu , stable@dpdk.org Subject: [PATCH v8 49/49] net/sxe2: fix devargs parse error check for representors Date: Tue, 1 Sep 2026 11:10:06 +0800 Message-ID: <20260901031006.3686638-1-liujie5@linkdatatechnology.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260831024549.3231744-1-liujie5@linkdatatechnology.com> References: <20260831024549.3231744-1-liujie5@linkdatatechnology.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowAAHdT8OQpZqSf8hBw--.61282S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Kr15tw4fAFy3Kr47CrW3KFg_yoW8Xr43pF 4kWFyIvFW5ta1Fqw45Za1rXF1Y9w40y3yjkFW0g34SkasxJrWUAryqga4j93W0k3srAF1I yF47trsFva1FgaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkE14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r 4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl Yx0E2Ix0cI8IcVAFwI0_Wrv_ZF1lYx0Ex4A2jsIE14v26F4j6r4UJwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4kE6xkIj40E w7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW7JVWDJwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_ Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUYFA JUUUUU= X-Originating-IP: [118.112.177.181] X-CM-SenderInfo: xolxyxrhv6zxpqngt3pdwhux5qro0w31of0z/ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jie Liu rte_eth_devargs_parse() returns a positive value (the number of representor ports) when a representor is specified in the device string, and a negative value on error. The old check treated any non-zero return as an error, so probing a representor device always failed. Only treat a negative return as an error, so the positive representor count is not misreported. Fixes: d8e4e075acb4 ("net/sxe2: add probing skeleton") Cc: stable@dpdk.org Signed-off-by: Jie Liu --- drivers/net/sxe2/sxe2_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sxe2/sxe2_ethdev.c b/drivers/net/sxe2/sxe2_ethdev.c index 8c60c9cfde..3871acdc77 100644 --- a/drivers/net/sxe2/sxe2_ethdev.c +++ b/drivers/net/sxe2/sxe2_ethdev.c @@ -2318,7 +2318,7 @@ static int32_t sxe2_parse_eth_devargs(struct rte_device *dev, ret = rte_eth_devargs_parse(dev->devargs->cls_str, eth_da, 1); - if (ret) { + if (ret < 0) { PMD_LOG_ERR(INIT, "Failed to parse device arguments: %s", dev->devargs->cls_str); return -rte_errno; @@ -2329,7 +2329,7 @@ static int32_t sxe2_parse_eth_devargs(struct rte_device *dev, ret = rte_eth_devargs_parse(dev->devargs->args, eth_da, 1); - if (ret) { + if (ret < 0) { PMD_LOG_ERR(INIT, "Failed to parse device arguments: %s", dev->devargs->args); return -rte_errno; -- 2.52.0