From: Guixin Liu <kanie@linux.alibaba.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Kees Cook" <kees@kernel.org>,
"Darshit Shah" <darnshah@amazon.de>,
"Brian Norris" <briannorris@chromium.org>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] PCI/DPC: Honor "pcie_ports=native" when enabling DPC
Date: Tue, 1 Sep 2026 14:45:54 +0800 [thread overview]
Message-ID: <20260901064554.2178688-1-kanie@linux.alibaba.com> (raw)
Commit 97ca178c899d ("PCI/DPC: Allow DPC on all Downstream Ports when
OS controls AER") replaced the AER service bit with host->native_aer
when deciding whether to create a DPC service device. Unlike the AER
service bit, host->native_aer does not reflect the "pcie_ports=native"
command-line override.
Consequently, if firmware retains AER control, "pcie_ports=native" no
longer enables DPC on Root Ports that advertise both AER and DPC, even
though the option is documented to force native DPC handling.
Check pcie_ports_native explicitly so both command-line overrides
continue to work.
Fixes: 97ca178c899d ("PCI/DPC: Allow DPC on all Downstream Ports when OS controls AER")
Cc: stable@vger.kernel.org
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
drivers/pci/pcie/portdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c
index a9cbfc1d2bc7..a05ee7980fb2 100644
--- a/drivers/pci/pcie/portdrv.c
+++ b/drivers/pci/pcie/portdrv.c
@@ -264,7 +264,7 @@ static int get_port_device_capability(struct pci_dev *dev)
*/
if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) &&
pci_aer_available() &&
- (pcie_ports_dpc_native || host->native_aer))
+ (pcie_ports_native || pcie_ports_dpc_native || host->native_aer))
services |= PCIE_PORT_SERVICE_DPC;
/* Enable bandwidth control if more than one speed is supported. */
--
2.43.7
next reply other threads:[~2026-09-01 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 6:45 Guixin Liu [this message]
2026-09-01 6:57 ` [PATCH] PCI/DPC: Honor "pcie_ports=native" when enabling DPC sashiko-bot
2026-09-03 23:05 ` Bjorn Helgaas
2026-09-04 2:34 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901064554.2178688-1-kanie@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=darnshah@amazon.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.