From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD047C61DD3 for ; Tue, 1 Sep 2026 08:27:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x1JpN-0003Gn-2K; Tue, 01 Sep 2026 04:26:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1JpM-0003GB-5H for qemu-arm@nongnu.org; Tue, 01 Sep 2026 04:26:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1JpK-0003L5-Mz for qemu-arm@nongnu.org; Tue, 01 Sep 2026 04:26:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788251202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qcBH9MRu+UyWrEdPkSpzYMK+ELNZvt65WCUQRlcZetQ=; b=ZjqDfykwW3zX6QW3XcoTmO813fbR2I3Ed0ZkNH29xatqGaO7/StMq1uz2X7mwHSqKHfzLa Qe1wdJj4Bqidmzlo4YDkLLAJmrpxubX16z3COU+fA/RgGmDt2cH/rTIUHk5wploMZx/5Bv Y9gFIpYy19mIz4Ix2Ti5wCVz5N2M/Hw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-yZNeiHhZNbCgD3UFJL-2sQ-1; Tue, 01 Sept 2026 04:26:30 -0400 X-MC-Unique: yZNeiHhZNbCgD3UFJL-2sQ-1 X-Mimecast-MFC-AGG-ID: yZNeiHhZNbCgD3UFJL-2sQ_1788251189 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9CC0419560B2; Tue, 1 Sep 2026 08:26:29 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.44.48.41]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4289418001CF; Tue, 1 Sep 2026 08:26:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A93881808E14; Tue, 01 Sep 2026 10:26:01 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Igor Mammedov , Peter Maydell , qemu-arm@nongnu.org, Ani Sinha , "Michael S. Tsirkin" Subject: [PULL 13/13] hw/misc/vmlaunchupdate: do not clear control bits upon fw-cfg select op Date: Tue, 1 Sep 2026 10:25:46 +0200 Message-ID: <20260901082554.804169-14-kraxel@redhat.com> In-Reply-To: <20260901082554.804169-1-kraxel@redhat.com> References: <20260901082554.804169-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: kwP24viqlV8T2gCGZFIvZlgLibTpAbDU0M4hxSRkOFE_1788251189 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org From: Ani Sinha The control bits define the behavior of the interface and clearing the bits upon reading or select operation will break that behavior. For example, after CTL_HOST_IGVM is set by the guest through a write and then subsequently, if the guest tried to read back the values from the fw-cfg interface, the read would clear CTL_HOST_IGVM. This would break restoring the host IGVM upon subsequent reset. Fixes: 30688c02a76e50e4 ("hw/misc/vmlaunchupdate: Introduce hypervisor fw-cfg interface support") Signed-off-by: Ani Sinha Message-ID: <20260825124139.6900-1-anisinha@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/misc/vmlaunchupdate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/misc/vmlaunchupdate.c b/hw/misc/vmlaunchupdate.c index afa2d278aefc..847d2d963f10 100644 --- a/hw/misc/vmlaunchupdate.c +++ b/hw/misc/vmlaunchupdate.c @@ -41,7 +41,6 @@ static bool vmlaunchupdate_supported(void) static void init_vm_launch_update(VMLaunchUpdateState *s) { s->launch_update.capabilities = VM_LAUNCHUPDATE_FORMAT_IGVM; - s->launch_update.control = 0; if (s->disabled) { s->launch_update.control |= VM_LAUNCHUPDATE_CTL_DISABLE; -- 2.55.0