Re: [PATCH v9 1/6] dt-bindings: spmi: apple,spmi: Add t603x and t8122

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing required `power-domains` property for not-always-on SPMI controllers.
- [Low] Missing example coverage for new interrupt controller capabilities.
--

commit 57c88d4c6dd7d628065665fa42a855aa5ac54ce4
Author: Sasha Finkelstein <k@chaosmail.tech>

dt-bindings: spmi: apple,spmi: Add t603x and t8122

This commit adds the t603x and t8122 compatibles for apple,spmi. It introduces
interrupt support and support for SPMI controllers that are not always-on.

> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> index 3e5b14bc8c317..4e73083ecec33 100644
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
[ ... ]
> @@ -34,10 +37,36 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +    description: Optional, operates in polled mode if not present
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - apple,t8122-spmi
> +          - apple,t6030-spmi
> +          - apple,t6031-spmi
> +then:
> +  required:
> +    - interrupt-controller
> +    - "#interrupt-cells"
> +    - interrupts

[Severity: Medium]
Looking at this if-then block in Documentation/devicetree/bindings/spmi/apple,spmi.yaml,
does it also need to mandate power-domains?

The commit message mentions adding support for SPMI controllers that are
not always-on (corresponding to the newly introduced t6030, t6031, and t8122).
For not-always-on hardware to be accessible without triggering a synchronous
external abort (kernel crash) on register read/write, the driver core must
power it on prior to the driver's probe.

This mechanism relies on the power-domains property being present in the
device tree node. Although power-domains is added to the properties list,
omitting it from this required list allows incomplete device trees to silently
pass schema validation.

> +
>  unevaluatedProperties: false
>  
>  examples:

[Severity: Low]
Looking at the examples section in Documentation/devicetree/bindings/spmi/apple,spmi.yaml,
does it provide coverage for the new interrupt controller capabilities?

The patch adds interrupt controller capabilities to the new hardware variants
(t6030, t6031, t8122) and makes interrupt-controller and #interrupt-cells
conditionally required. However, the existing examples section only uses the
apple,t6000-spmi compatible, which does not trigger the new if-then block
condition:

    spmi@920a1300 {
        compatible = "apple,t6000-spmi", "apple,spmi";

Because of this, the newly added conditionally required properties and their
constraints are completely bypassed and remain untested by schema validation
tools.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-t603x-spmi-v9-0-09e702e3b153@chaosmail.tech?part=1