From: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: uma.shankar@intel.com,
Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Subject: [v2 2/2] drm/i915/color: Add YUV buffer support on HDR planes
Date: Tue, 1 Sep 2026 17:32:54 +0530 [thread overview]
Message-ID: <20260901120254.629261-3-chaitanya.kumar.borah@intel.com> (raw)
In-Reply-To: <20260901120254.629261-1-chaitanya.kumar.borah@intel.com>
Add the INTEL_PLANE_CB_CSC_FF (fixed function CSC) color block as the
first stage for the HDR planes. This enables YUV-to-RGB color space
conversion on HDR planes via the color pipeline.
Also in icl_program_input_csc(), account for the color pipeline
programming, in addition to FB format.
v2:
- Increase MAX_COLOROP to 5 (Sashiko)
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
drivers/gpu/drm/i915/display/intel_color_pipeline.c | 4 +++-
drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_color_pipeline.c b/drivers/gpu/drm/i915/display/intel_color_pipeline.c
index 38cfd6ed585d..7fc31fe891a8 100644
--- a/drivers/gpu/drm/i915/display/intel_color_pipeline.c
+++ b/drivers/gpu/drm/i915/display/intel_color_pipeline.c
@@ -12,7 +12,7 @@
#include "skl_universal_plane.h"
#define MAX_COLOR_PIPELINES 1
-#define MAX_COLOROP 4
+#define MAX_COLOROP 5
#define PLANE_DEGAMMA_SIZE 128
#define PLANE_GAMMA_SIZE 32
@@ -31,6 +31,7 @@ static const struct drm_colorop_funcs intel_colorop_funcs = {
* the pipeline totally unusable.
*/
static const enum intel_color_block xe3plpd_primary_plane_pipeline[] = {
+ INTEL_PLANE_CB_CSC_FF,
INTEL_PLANE_CB_PRE_CSC_LUT,
INTEL_PLANE_CB_CSC,
INTEL_PLANE_CB_3DLUT,
@@ -38,6 +39,7 @@ static const enum intel_color_block xe3plpd_primary_plane_pipeline[] = {
};
static const enum intel_color_block hdr_plane_pipeline[] = {
+ INTEL_PLANE_CB_CSC_FF,
INTEL_PLANE_CB_PRE_CSC_LUT,
INTEL_PLANE_CB_CSC,
INTEL_PLANE_CB_POST_CSC_LUT,
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 0f604bdb4c62..2e5bf02b480f 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1626,7 +1626,8 @@ icl_plane_update_noarm(struct intel_dsb *dsb,
intel_de_write_dsb(display, dsb, PLANE_COLOR_CTL(pipe, plane_id),
plane_color_ctl);
- if (fb->format->is_yuv && icl_is_hdr_plane(display, plane_id))
+ if (icl_is_hdr_plane(display, plane_id) &&
+ (fb->format->is_yuv || plane_state->hw.csc_ff_enable))
icl_program_input_csc(dsb, plane, plane_state);
skl_write_plane_wm(dsb, plane, crtc_state);
--
2.50.1
next prev parent reply other threads:[~2026-09-01 12:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 12:02 [v2 0/2] Support YUV buffers in HDR planes Chaitanya Kumar Borah
2026-09-01 12:02 ` [DO_NOT_REVIEW v2 1/2] drm/i915/color: Add color pipeline support for SDR planes Chaitanya Kumar Borah
2026-09-01 12:59 ` sashiko-bot
2026-09-01 12:02 ` Chaitanya Kumar Borah [this message]
2026-09-01 14:34 ` [v2 2/2] drm/i915/color: Add YUV buffer support on HDR planes Shankar, Uma
2026-09-01 12:39 ` ✓ CI.KUnit: success for Support YUV buffers in HDR planes (rev2) Patchwork
2026-09-01 14:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-01 16:04 ` ✓ i915.CI.BAT: " Patchwork
2026-09-01 16:44 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-01 23:33 ` ✗ i915.CI.Full: failure " Patchwork
2026-09-16 9:40 ` [v2 0/2] Support YUV buffers in HDR planes Borah, Chaitanya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901120254.629261-3-chaitanya.kumar.borah@intel.com \
--to=chaitanya.kumar.borah@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.