From: Heiko Carstens <hca@linux.ibm.com>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, stable@vger.kernel.org,
Jan Polensky <japo@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH v9 3/3] s390/pai: Support CPU hotplug for PMU PAI
Date: Tue, 1 Sep 2026 16:19:42 +0200 [thread overview]
Message-ID: <20260901141942.14482E83-hca@linux.ibm.com> (raw)
In-Reply-To: <20260901123320.670897-4-tmricht@linux.ibm.com>
On Tue, Sep 01, 2026 at 02:33:20PM +0200, Thomas Richter wrote:
> + /* CPUHP_BP_PREPARE_DYN --> before CPU is brought online */
> + rc = cpuhp_setup_state(CPUHP_BP_PREPARE_DYN, "perf/pai:prepare",
> + pai_online_cpu, pai_offline_cpu);
> + if (rc < 0)
> + goto out_debug;
> +
> if (!paipmu_setup()) {
> /* No PMU registration, no need for debug buffer */
> - debug_unregister_view(paidbg, &debug_sprintf_view);
> - debug_unregister(paidbg);
> - return -ENODEV;
> + rc = -ENODEV;
> + goto out_cpuhp;
> }
> return 0;
> +
> +out_cpuhp:
> + cpuhp_remove_state(rc);
This would now use "-ENODEV" as state for cpuhp_remove_state. I fixed
it up since I suggested this code, so you can blame me in any case.
next prev parent reply other threads:[~2026-09-01 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 12:33 [PATCH v9 0/3] Add CPU hotplug support for PAI PMU Thomas Richter
2026-09-01 12:33 ` [PATCH v9 1/3] s390/pai: Use PAI PMU index as parameter replacing event Thomas Richter
2026-09-01 12:33 ` [PATCH v9 2/3] s390/pai: Move locking to event init and delete Thomas Richter
2026-09-01 12:33 ` [PATCH v9 3/3] s390/pai: Support CPU hotplug for PMU PAI Thomas Richter
2026-09-01 14:19 ` Heiko Carstens [this message]
2026-09-02 6:23 ` Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901141942.14482E83-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=japo@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.