From: "Rob Herring (Arm)" <robh@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] ASoC: ak4642: Drop "clocks" property presence check
Date: Tue, 1 Sep 2026 10:28:38 -0500 [thread overview]
Message-ID: <20260901152838.795864-1-robh@kernel.org> (raw)
of_property_read_bool() should only be used on boolean properties and
not used as a presence check. The of_clk_get_parent_name() function
returns NULL if the "clocks" property is not present, so there is no
need to check for presence first.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
- Just drop the presence check instead of using of_property_present()
- Split to separate patch
---
sound/soc/codecs/ak4642.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 08ec2035b270..4f86728cbe0a 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -607,14 +607,13 @@ static struct clk *ak4642_of_parse_mcko(struct device *dev)
struct device_node *np = dev->of_node;
struct clk *clk;
const char *clk_name = np->name;
- const char *parent_clk_name = NULL;
+ const char *parent_clk_name;
u32 rate;
if (of_property_read_u32(np, "clock-frequency", &rate))
return NULL;
- if (of_property_read_bool(np, "clocks"))
- parent_clk_name = of_clk_get_parent_name(np, 0);
+ parent_clk_name = of_clk_get_parent_name(np, 0);
of_property_read_string(np, "clock-output-names", &clk_name);
--
2.53.0
next reply other threads:[~2026-09-01 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 15:28 Rob Herring (Arm) [this message]
2026-09-01 18:40 ` [PATCH v2] ASoC: ak4642: Drop "clocks" property presence check Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901152838.795864-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.