From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA1C5C624D3 for ; Tue, 1 Sep 2026 15:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9N88W+EKLCaorztNjW8oY9UyG6XFTw8nQFgNeNkHIls=; b=AmqP7mGkt1+3w0 nqik6FjWeeEl3z3BXwaoAqiA4gg/4nPhh2kOFzZMN5IVny3cU/rqGE0mR4C6zfCR/DjS36jlLZAsr oupTHaI3rLzxUBuHvph+OZe396gzct/CGFjnaZiT6LD/LyD9R87f2q4rNg5wR+a7gHLMz1I7sLaKi bbnR062M+3H7A2VAK03mjdZXZoW6QW/KQHc0DoPk47RsBO0cCzYNJTpCU//9pzu/uObbAR6DhwLbz xLa4Zp0vx9AiuAUp0R8Kj2u9546aS1JSWDz5K5fbRRmeP1VcpMDY/UyzQ1iBoosMR0/V0D3XtpdCA asYX3mVSkSPhhZ5idUwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1Qtf-0000000Cbkk-1fyM; Tue, 01 Sep 2026 15:59:39 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1Qtd-0000000Cbk3-2IO0 for linux-phy@lists.infradead.org; Tue, 01 Sep 2026 15:59:37 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B32CB6013A; Tue, 1 Sep 2026 15:59:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E77AF1F000E9; Tue, 1 Sep 2026 15:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788278376; bh=7j42vq1/p7q82MIrqQwSAqyGBwrFxI6uBLhdizLdlxk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Zj10QOWNMDTDgFraeo2mB4lb7NaR4gsZAX9Sk3grKtRtu0tslrTf1d3FEKfftrQVk +hLRyjgZFB824IJijNdDhtSQmLjYxzDHiO6jmrTe3I6bFSICuDPMhj1BGwtG0K1jn0 +f/c5SBRwjN9Ke54kHnlKhkVnNu7KlGetqeYVieu+UCZTqgkaPlFFRXKdTnhra8tSN 2/v0VMUv0mWrZXc1GHDT7BP1nbghfynwmukmzMc0SX7+9UpttxWmkCnXTgwBajyfEy NMJbDlVUQxfgjQAe0lJjPuLfIRo5qWH/+JEt3mno5H0nWfK0Kfma0YdeKz5BY/PnUU IFX8lzldgLASg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 08/24] scsi: ufs: mediatek: Add dual 0.9V supply support To: "Louis-Alexis Eyraud" Cc: linux-scsi@vger.kernel.org, conor+dt@kernel.org, vkoul@kernel.org, robh@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260901-mt8196-ufs-v11-8-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> <20260901-mt8196-ufs-v11-8-dbd007704490@collabora.com> Date: Tue, 01 Sep 2026 15:59:35 +0000 Message-Id: <20260901155935.E77AF1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3Npbmcgcm9sbGJh Y2sgb2YgYXZkZDA5IHJlZ3VsYXRvciBzdGF0ZSBvbiBhdmRkMDktMSBlcnJvciBwYXRocyBpbiB1 ZnNfbXRrXzA5dl9vbigpIGFuZCB1ZnNfbXRrXzA5dl9vZmYoKS4KLSBbTWVkaXVtXSBJbmNvcnJl Y3QgdmFyaWFibGUgcGFzc2VkIHRvICVwZSBmb3JtYXQgc3BlY2lmaWVyIGluIGRldl9lcnJfcHJv YmUoKSBmb3IgYXZkZDA5LTEgcmVndWxhdG9yIGVycm9yLgotLQoKY29tbWl0IDIzMzI3MTgxMTkw M2JlZjY4OGYwMzA3NjU2NGU4YWU1Nzk2NTAxNGMKQXV0aG9yOiBMb3Vpcy1BbGV4aXMgRXlyYXVk IDxsb3Vpc2FsZXhpcy5leXJhdWRAY29sbGFib3JhLmNvbT4KCnNjc2k6IHVmczogbWVkaWF0ZWs6 IEFkZCBkdWFsIDAuOVYgc3VwcGx5IHN1cHBvcnQKClRoZSBNVDgxOTYgU29DIGhhcyBhbiBhZGRp dGlvbmFsIHBpbiBjb21wYXJlZCB0byB0aGUgTVQ4MTgzIFNvQyB0byBmZWVkCnRoZSBob3N0IGNv bnRyb2xsZXIgd2l0aCBhIDAuOVYgc3VwcGx5LiBUaGlzIHBhdGNoIGFkZHMgbWFuYWdlbWVudCBm b3IgYQpzZWNvbmQgb3B0aW9uYWwgMC45ViByZWd1bGF0b3IgbmFtZWQgImF2ZGQwOS0xIiBpbiBw cmVwYXJhdGlvbiBmb3IgdGhpcwpTb0Mgc3VwcG9ydC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv dWZzL2hvc3QvdWZzLW1lZGlhdGVrLmMgYi9kcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5j Cj4gaW5kZXggZWI3YTBjYzQ2NGY0My4uZjI5OGVhNmY2ZWNiOSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jCj4gKysrIGIvZHJpdmVycy91ZnMvaG9zdC91ZnMt bWVkaWF0ZWsuYwo+IEBAIC01MTUsMTYgKzUxNiwyOSBAQCBzdGF0aWMgaW50IHVmc19tdGtfMDl2 X29mZihzdHJ1Y3QgdWZzX210a19ob3N0ICpob3N0KQo+ICAJc3RydWN0IGFybV9zbWNjY19yZXMg cmVzOwo+ICAJaW50IHJldDsKPiAgCj4gLQlpZiAoIWhvc3QtPnJlZ19hdmRkMDkpCj4gKwlpZiAo IWhvc3QtPnJlZ19hdmRkMDkgJiYgIWhvc3QtPnJlZ19hdmRkMDlfMSkKPiAgCQlyZXR1cm4gMDsK PiAgCj4gIAl1ZnNfbXRrX3ZhMDlfcHdyX2N0cmwocmVzLCAwKTsKPiAtCXJldCA9IHJlZ3VsYXRv cl9kaXNhYmxlKGhvc3QtPnJlZ19hdmRkMDkpOwo+IC0JaWYgKHJldCkgewo+IC0JCWRldl9lcnIo aG9zdC0+aGJhLT5kZXYsICJGYWlsZWQgdG8gZGlzYWJsZSBhdmRkMDktc3VwcGx5OiAlcGVcbiIs Cj4gLQkJCUVSUl9QVFIocmV0KSk7Cj4gLQkJdWZzX210a192YTA5X3B3cl9jdHJsKHJlcywgMSk7 Cj4gLQkJcmV0dXJuIHJldDsKPiArCj4gKwlpZiAoaG9zdC0+cmVnX2F2ZGQwOSkgewo+ICsJCXJl dCA9IHJlZ3VsYXRvcl9kaXNhYmxlKGhvc3QtPnJlZ19hdmRkMDkpOwo+ICsJCWlmIChyZXQpIHsK PiArCQkJZGV2X2Vycihob3N0LT5oYmEtPmRldiwgIkZhaWxlZCB0byBkaXNhYmxlIGF2ZGQwOS1z dXBwbHk6ICVwZVxuIiwKPiArCQkJCUVSUl9QVFIocmV0KSk7Cj4gKwkJCXVmc19tdGtfdmEwOV9w d3JfY3RybChyZXMsIDEpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0KPiArCj4gKwlp ZiAoaG9zdC0+cmVnX2F2ZGQwOV8xKSB7Cj4gKwkJcmV0ID0gcmVndWxhdG9yX2Rpc2FibGUoaG9z dC0+cmVnX2F2ZGQwOV8xKTsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCWRldl9lcnIoaG9zdC0+aGJh LT5kZXYsICJGYWlsZWQgdG8gZGlzYWJsZSBhdmRkMDktMS1zdXBwbHk6ICVwZVxuIiwKPiArCQkJ CUVSUl9QVFIocmV0KSk7Cj4gKwkJCXVmc19tdGtfdmEwOV9wd3JfY3RybChyZXMsIDEpOwo+ICsJ CQlyZXR1cm4gcmV0Owo+ICsJCX0KCltTZXZlcml0eTogSGlnaF0KRG9lcyB0aGlzIGVycm9yIHBh dGggbGVhdmUgaG9zdC0+cmVnX2F2ZGQwOSBkaXNhYmxlZCBpZiBkaXNhYmxpbmcKaG9zdC0+cmVn X2F2ZGQwOV8xIGZhaWxzPwoKSWYgdGhlIHNlY29uZCBkaXNhYmxlIGZhaWxzLCByZXR1cm5pbmcg aGVyZSBtZWFucyB0aGUgcG93ZXIgc3RhdGUgYmVjb21lcwpkZXN5bmNocm9uaXplZC4gU2hvdWxk IGhvc3QtPnJlZ19hdmRkMDkgYmUgcmUtZW5hYmxlZCBoZXJlIHRvIG1hdGNoIHRoZQpkcml2ZXIn cyBleHBlY3RlZCBzdGF0ZSBiZWZvcmUgcmV0dXJuaW5nIHRoZSBlcnJvcj8KCj4gIAl9Cj4gIAo+ ICAJcmV0dXJuIDA7Cj4gQEAgLTUzNSwxNCArNTQ5LDI1IEBAIHN0YXRpYyBpbnQgdWZzX210a18w OXZfb24oc3RydWN0IHVmc19tdGtfaG9zdCAqaG9zdCkKPiAgCXN0cnVjdCBhcm1fc21jY2NfcmVz IHJlczsKPiAgCWludCByZXQ7Cj4gIAo+IC0JaWYgKCFob3N0LT5yZWdfYXZkZDA5KQo+ICsJaWYg KCFob3N0LT5yZWdfYXZkZDA5ICYmICFob3N0LT5yZWdfYXZkZDA5XzEpCj4gIAkJcmV0dXJuIDA7 Cj4gIAo+IC0JcmV0ID0gcmVndWxhdG9yX2VuYWJsZShob3N0LT5yZWdfYXZkZDA5KTsKPiAtCWlm IChyZXQpIHsKPiAtCQlkZXZfZXJyKGhvc3QtPmhiYS0+ZGV2LCAiRmFpbGVkIHRvIGVuYWJsZSBh dmRkMDktc3VwcGx5OiAlcGVcbiIsCj4gLQkJCUVSUl9QVFIocmV0KSk7Cj4gLQkJcmV0dXJuIHJl dDsKPiArCWlmIChob3N0LT5yZWdfYXZkZDA5KSB7Cj4gKwkJcmV0ID0gcmVndWxhdG9yX2VuYWJs ZShob3N0LT5yZWdfYXZkZDA5KTsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCWRldl9lcnIoaG9zdC0+ aGJhLT5kZXYsICJGYWlsZWQgdG8gZW5hYmxlIGF2ZGQwOS1zdXBwbHk6ICVwZVxuIiwKPiArCQkJ CUVSUl9QVFIocmV0KSk7Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWlm IChob3N0LT5yZWdfYXZkZDA5XzEpIHsKPiArCQlyZXQgPSByZWd1bGF0b3JfZW5hYmxlKGhvc3Qt PnJlZ19hdmRkMDlfMSk7Cj4gKwkJaWYgKHJldCkgewo+ICsJCQlkZXZfZXJyKGhvc3QtPmhiYS0+ ZGV2LCAiRmFpbGVkIHRvIGVuYWJsZSBhdmRkMDktMS1zdXBwbHk6ICVwZVxuIiwKPiArCQkJCUVS Ul9QVFIocmV0KSk7Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwkJfQoKW1NldmVyaXR5OiBIaWdoXQpE b2VzIHRoaXMgcGF0aCBsZWFrIGEgcmVmZXJlbmNlIGNvdW50IGZvciBob3N0LT5yZWdfYXZkZDA5 PwoKSWYgZW5hYmxpbmcgaG9zdC0+cmVnX2F2ZGQwOV8xIGZhaWxzIGFmdGVyIGhvc3QtPnJlZ19h dmRkMDkgd2FzIHN1Y2Nlc3NmdWxseQplbmFibGVkLCB0aGUgZnVuY3Rpb24gcmV0dXJucyBpbW1l ZGlhdGVseSB3aXRob3V0IGRpc2FibGluZyBob3N0LT5yZWdfYXZkZDA5LgpTaG91bGQgaG9zdC0+ cmVnX2F2ZGQwOSBiZSBkaXNhYmxlZCBiZWZvcmUgcmV0dXJuaW5nPwoKPiAgCX0KPiAgCj4gIAl1 ZnNfbXRrX3ZhMDlfcHdyX2N0cmwocmVzLCAxKTsKPiBAQCAtMTIzMiwyMCArMTI1NywzMyBAQCBz dGF0aWMgaW50IHVmc19tdGtfZ2V0X3N1cHBsaWVzKHN0cnVjdCB1ZnNfbXRrX2hvc3QgKmhvc3Qp Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBob3N0LT5oYmEtPmRldjsKPiAgCWNvbnN0IHN0cnVj dCB1ZnNfbXRrX3NvY19kYXRhICpkYXRhID0gb2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKGRldik7 Cj4gIAo+IC0JaWYgKCFkYXRhIHx8ICFkYXRhLT5oYXNfYXZkZDA5KQo+ICsJaWYgKCFkYXRhKQo+ ICAJCXJldHVybiAwOwoKWyAuLi4gXQoKPiArCWlmIChkYXRhLT5oYXNfYXZkZDA5XzEpIHsKPiAr CQlob3N0LT5yZWdfYXZkZDA5XzEgPSBkZXZtX3JlZ3VsYXRvcl9nZXRfb3B0aW9uYWwoZGV2LCAi YXZkZDA5LTEiKTsKPiArCQlpZiAoSVNfRVJSKGhvc3QtPnJlZ19hdmRkMDlfMSkpIHsKPiArCQkJ aWYgKFBUUl9FUlIoaG9zdC0+cmVnX2F2ZGQwOV8xKSAhPSAtRU5PREVWKSB7Cj4gKwkJCQlyZXR1 cm4gZGV2X2Vycl9wcm9iZShkZXYsCj4gKwkJCQkJCSAgICAgUFRSX0VSUihob3N0LT5yZWdfYXZk ZDA5XzEpLAo+ICsJCQkJCQkgICAgICJGYWlsZWQgdG8gZ2V0IGF2ZGQwOS0xIHJlZ3VsYXRvcjog JXBlXG4iLAo+ICsJCQkJCQkgICAgIGhvc3QtPnJlZ19hdmRkMDkpOwoKW1NldmVyaXR5OiBNZWRp dW1dCkFyZSB3ZSBwYXNzaW5nIHRoZSBjb3JyZWN0IHZhcmlhYmxlIHRvIHRoZSAlcGUgZm9ybWF0 IHNwZWNpZmllciBoZXJlPwoKSXQgbG9va3MgbGlrZSBob3N0LT5yZWdfYXZkZDA5IGlzIHBhc3Nl ZCBpbnN0ZWFkIG9mIGhvc3QtPnJlZ19hdmRkMDlfMSwgd2hpY2gKd291bGQgY2F1c2UgZGV2X2Vy cl9wcm9iZSgpIHRvIHByaW50IHRoZSBwb2ludGVyIHZhbHVlIG9yIGhhc2ggb2YgdGhlIHdyb25n CnJlZ3VsYXRvciBpbnN0ZWFkIG9mIHRoZSBhY3R1YWwgZXJyb3Igc3RyaW5nLgoKPiArCQkJfQo+ ICsJCQlob3N0LT5yZWdfYXZkZDA5XzEgPSBOVUxMOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAlyZXR1 cm4gMDsKCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0 Y2hzZXQvMjAyNjA5MDEtbXQ4MTk2LXVmcy12MTEtMC1kYmQwMDc3MDQ0OTBAY29sbGFib3JhLmNv bT9wYXJ0PTgKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E62351C35; Tue, 1 Sep 2026 15:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788278378; cv=none; b=OM5g/qCun7cTLGxecmok8lqAM4O+32VzjwTRJ7B4LPyIXkHendQmsefT2lnM6XBOPuaBjOF1lKScXS/6s+NH/8uNnvCAUDhrrGSTc8KEgmoq96BvgdhCJmfRVO2JnqaIN+Pw/q670IkEFXY17o8VFaXOmyvPs0ClYlbZ4oDJpNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788278378; c=relaxed/simple; bh=ydbCa8n4Y3WIrgtlIEtnDhkmJHb5HWM0k/pUfqpiBoc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=uHrINoStCkyVw6PBohBDeiBP6Ff/MKkk65xcb7zv8XF0gMTpTUL6Z8u8Qnw2866+YfgefCdP82raYUfMEwrD+/gXIxbMdXkVSRG5iwm3y3CAXnd952C/mH/wkQxU+F98ZVWyt4nh3eBI+ih7DrEenuPbx9QMiWMm8CO/46NFHd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zj10QOWN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zj10QOWN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E77AF1F000E9; Tue, 1 Sep 2026 15:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788278376; bh=7j42vq1/p7q82MIrqQwSAqyGBwrFxI6uBLhdizLdlxk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Zj10QOWNMDTDgFraeo2mB4lb7NaR4gsZAX9Sk3grKtRtu0tslrTf1d3FEKfftrQVk +hLRyjgZFB824IJijNdDhtSQmLjYxzDHiO6jmrTe3I6bFSICuDPMhj1BGwtG0K1jn0 +f/c5SBRwjN9Ke54kHnlKhkVnNu7KlGetqeYVieu+UCZTqgkaPlFFRXKdTnhra8tSN 2/v0VMUv0mWrZXc1GHDT7BP1nbghfynwmukmzMc0SX7+9UpttxWmkCnXTgwBajyfEy NMJbDlVUQxfgjQAe0lJjPuLfIRo5qWH/+JEt3mno5H0nWfK0Kfma0YdeKz5BY/PnUU IFX8lzldgLASg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 08/24] scsi: ufs: mediatek: Add dual 0.9V supply support Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: linux-scsi@vger.kernel.org, conor+dt@kernel.org, vkoul@kernel.org, robh@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260901-mt8196-ufs-v11-8-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> <20260901-mt8196-ufs-v11-8-dbd007704490@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 01 Sep 2026 15:59:35 +0000 Message-Id: <20260901155935.E77AF1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Missing rollback of avdd09 regulator state on avdd09-1 error paths= in ufs_mtk_09v_on() and ufs_mtk_09v_off(). - [Medium] Incorrect variable passed to %pe format specifier in dev_err_pro= be() for avdd09-1 regulator error. -- commit 233271811903bef688f03076564e8ae57965014c Author: Louis-Alexis Eyraud scsi: ufs: mediatek: Add dual 0.9V supply support The MT8196 SoC has an additional pin compared to the MT8183 SoC to feed the host controller with a 0.9V supply. This patch adds management for a second optional 0.9V regulator named "avdd09-1" in preparation for this SoC support. > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media= tek.c > index eb7a0cc464f43..f298ea6f6ecb9 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -515,16 +516,29 @@ static int ufs_mtk_09v_off(struct ufs_mtk_host *hos= t) > struct arm_smccc_res res; > int ret; > =20 > - if (!host->reg_avdd09) > + if (!host->reg_avdd09 && !host->reg_avdd09_1) > return 0; > =20 > ufs_mtk_va09_pwr_ctrl(res, 0); > - ret =3D regulator_disable(host->reg_avdd09); > - if (ret) { > - dev_err(host->hba->dev, "Failed to disable avdd09-supply: %pe\n", > - ERR_PTR(ret)); > - ufs_mtk_va09_pwr_ctrl(res, 1); > - return ret; > + > + if (host->reg_avdd09) { > + ret =3D regulator_disable(host->reg_avdd09); > + if (ret) { > + dev_err(host->hba->dev, "Failed to disable avdd09-supply: %pe\n", > + ERR_PTR(ret)); > + ufs_mtk_va09_pwr_ctrl(res, 1); > + return ret; > + } > + } > + > + if (host->reg_avdd09_1) { > + ret =3D regulator_disable(host->reg_avdd09_1); > + if (ret) { > + dev_err(host->hba->dev, "Failed to disable avdd09-1-supply: %pe\n", > + ERR_PTR(ret)); > + ufs_mtk_va09_pwr_ctrl(res, 1); > + return ret; > + } [Severity: High] Does this error path leave host->reg_avdd09 disabled if disabling host->reg_avdd09_1 fails? If the second disable fails, returning here means the power state becomes desynchronized. Should host->reg_avdd09 be re-enabled here to match the driver's expected state before returning the error? > } > =20 > return 0; > @@ -535,14 +549,25 @@ static int ufs_mtk_09v_on(struct ufs_mtk_host *host) > struct arm_smccc_res res; > int ret; > =20 > - if (!host->reg_avdd09) > + if (!host->reg_avdd09 && !host->reg_avdd09_1) > return 0; > =20 > - ret =3D regulator_enable(host->reg_avdd09); > - if (ret) { > - dev_err(host->hba->dev, "Failed to enable avdd09-supply: %pe\n", > - ERR_PTR(ret)); > - return ret; > + if (host->reg_avdd09) { > + ret =3D regulator_enable(host->reg_avdd09); > + if (ret) { > + dev_err(host->hba->dev, "Failed to enable avdd09-supply: %pe\n", > + ERR_PTR(ret)); > + return ret; > + } > + } > + > + if (host->reg_avdd09_1) { > + ret =3D regulator_enable(host->reg_avdd09_1); > + if (ret) { > + dev_err(host->hba->dev, "Failed to enable avdd09-1-supply: %pe\n", > + ERR_PTR(ret)); > + return ret; > + } [Severity: High] Does this path leak a reference count for host->reg_avdd09? If enabling host->reg_avdd09_1 fails after host->reg_avdd09 was successfully enabled, the function returns immediately without disabling host->reg_avdd0= 9. Should host->reg_avdd09 be disabled before returning? > } > =20 > ufs_mtk_va09_pwr_ctrl(res, 1); > @@ -1232,20 +1257,33 @@ static int ufs_mtk_get_supplies(struct ufs_mtk_ho= st *host) > struct device *dev =3D host->hba->dev; > const struct ufs_mtk_soc_data *data =3D of_device_get_match_data(dev); > =20 > - if (!data || !data->has_avdd09) > + if (!data) > return 0; [ ... ] > + if (data->has_avdd09_1) { > + host->reg_avdd09_1 =3D devm_regulator_get_optional(dev, "avdd09-1"); > + if (IS_ERR(host->reg_avdd09_1)) { > + if (PTR_ERR(host->reg_avdd09_1) !=3D -ENODEV) { > + return dev_err_probe(dev, > + PTR_ERR(host->reg_avdd09_1), > + "Failed to get avdd09-1 regulator: %pe\n", > + host->reg_avdd09); [Severity: Medium] Are we passing the correct variable to the %pe format specifier here? It looks like host->reg_avdd09 is passed instead of host->reg_avdd09_1, whi= ch would cause dev_err_probe() to print the pointer value or hash of the wrong regulator instead of the actual error string. > + } > + host->reg_avdd09_1 =3D NULL; > + } > } > =20 > return 0; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260901-mt8196-ufs= -v11-0-dbd007704490@collabora.com?part=3D8