From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ABBAC624D3 for ; Tue, 1 Sep 2026 16:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GbOISSbA7GEBrlz2HXhRwc1/VvSDThyt60DXR3i6JMk=; b=CPR3GY22xb1pcC 9Pz6hWMWCQ4w9ulx2FVz3CWVVKBxIfaInocBjHLq23u5Tlhq/vY9Cv+hQtznddkmKs3lzVyJWCJhj SEBL1ZY6UpDJDElTkVIInVEeceMYaV61P1j52wSdJtEXCBT4fGh868pYDN0QSedfExf4Prws25VJg uVvLcchkFlr8TqHIJOHK0RBfetAIFbKewxsJNa77LDLuBUmYHQLMyXGvSAoV0LyDzkaxjzDvOBswN VvkWIZj0uHAAKKitTG6r9uBWZV0SIy9GW0MZd29SDPnUiiI4A8yOVr5knOcK4MDPui5c2boKDxCUQ rlEYXW5cQ5AYTxhxVtOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1RK0-0000000CetT-44sJ; Tue, 01 Sep 2026 16:26:52 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1RJz-0000000Cesv-02uI for linux-phy@lists.infradead.org; Tue, 01 Sep 2026 16:26:51 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8F64840BDA; Tue, 1 Sep 2026 16:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5B6D1F000E9; Tue, 1 Sep 2026 16:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788280010; bh=NVCcuS1Pbbtguh8VUMzbatetxCy9mJfpPGOgAUSyILU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SA7rYR8LHLfmH2XL38prYerkgTaI3USKMEzKCDKkQJ/XHEmTANnpxpxEYIzO0xTf3 LBNN4bnHGVA4Yq+K3BN+5WE1sTO6qaLLvZvuUJ646vLNUr15PwwNsj4qghbb/JhElI Z3FP3IZucbZhN62JzR/LAoJ+RZbxJVn4FBfvMONeB5XSI42K1H8l0YdcLScTmtedO4 /ex1ndktdXkxd1p7p9y3iwoSNR0E65nJC6ogd6NrgnQxm9+2a66aTOBTdI9kLpf4yP 6b39Tj0ijp18Cxb9jk8u8KozbDs9QAgf+02v87bu4BDi2FYnsQtA/1fvaIn7B1CqUY VyabUpqeuhpag== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 22/24] scsi: ufs: mediatek: Remove ret local from link_startup_notify To: "Louis-Alexis Eyraud" Cc: conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260901-mt8196-ufs-v11-22-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> <20260901-mt8196-ufs-v11-22-dbd007704490@collabora.com> Date: Tue, 01 Sep 2026 16:26:49 +0000 Message-Id: <20260901162649.E5B6D1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUaGUgcmV0dXJuIHZhbHVlIG9mIHVmc2hjZF9kbWVfc2V0KCkgaXMgb3ZlcndyaXR0 ZW4gb24gTVQ2OTg5IHBsYXRmb3JtcyB3aXRob3V0IGJlaW5nIGNoZWNrZWQsIGxvc2luZyB0aGUg ZXJyb3Igc3RhdGUuCi0gW0hpZ2hdIFRoZSByZXR1cm4gdmFsdWUgb2YgdWZzX210a19hdXRvX2hp YmVybjhfZGlzYWJsZSgpIGlzIGNvbXBsZXRlbHkgaWdub3JlZCBpbiB1ZnNfbXRrX3B3cl9jaGFu Z2Vfbm90aWZ5KCkuCi0tCgpjb21taXQgODMyOWFjNzI2ZGU1OGQzYWEyNDUzZWIwZWQzMTllN2Zi YmZiMmE2ZApBdXRob3I6IE5pY29sYXMgRnJhdHRhcm9saSA8bmljb2xhcy5mcmF0dGFyb2xpQGNv bGxhYm9yYS5jb20+CgpzY3NpOiB1ZnM6IG1lZGlhdGVrOiBSZW1vdmUgcmV0IGxvY2FsIGZyb20g bGlua19zdGFydHVwX25vdGlmeQoKVGhpcyBjb21taXQgcmVtb3ZlcyB0aGUgdW51c2VkIGxvY2Fs IHJldCB2YXJpYWJsZSBmcm9tCnVmc19tdGtfbGlua19zdGFydHVwX25vdGlmeS4gSXQgYWxzbyBy ZWZhY3RvcnMgdGhlIGZ1bmN0aW9uIHRvIHJldHVybgpkaXJlY3RseSBmcm9tIHRoZSBzd2l0Y2gg c3RhdGVtZW50LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91ZnMvaG9zdC91ZnMtbWVkaWF0ZWsu YyBiL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmMKPiBpbmRleCA0NzgyZmRmNTQ4NjZi Li5iY2RlNThlM2FlZTg2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlh dGVrLmMKPiArKysgYi9kcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jCj4gQEAgLTE1NDMs MjEgKzE1NDMsMTUgQEAgc3RhdGljIHZvaWQgdWZzX210a19wb3N0X2xpbmsoc3RydWN0IHVmc19o YmEgKmhiYSkKPiAgc3RhdGljIGludCB1ZnNfbXRrX2xpbmtfc3RhcnR1cF9ub3RpZnkoc3RydWN0 IHVmc19oYmEgKmhiYSwKPiAgCQkJCSAgICAgICBlbnVtIHVmc19ub3RpZnlfY2hhbmdlX3N0YXR1 cyBzdGFnZSkKPiAgewo+IC0JaW50IHJldCA9IDA7Cj4gLQo+ICAJc3dpdGNoIChzdGFnZSkgewo+ ICAJY2FzZSBQUkVfQ0hBTkdFOgo+IC0JCXJldCA9IHVmc19tdGtfcHJlX2xpbmsoaGJhKTsKPiAt CQlicmVhazsKPiArCQlyZXR1cm4gdWZzX210a19wcmVfbGluayhoYmEpOwoKW1NldmVyaXR5OiBI aWdoXQpUaGlzIGlzbid0IGEgYnVnIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGxvb2tp bmcgYXQgdWZzX210a19wcmVfbGluaygpCndoaWNoIGlzIGNhbGxlZCBoZXJlOgoKZHJpdmVycy91 ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYzp1ZnNfbXRrX3ByZV9saW5rKCkgewoJLi4uCglyZXQgPSB1 ZnNoY2RfZG1lX3NldChoYmEsIFVJQ19BUkdfTUlCKFZTX1NBVkVQT1dFUkNPTlRST0wpLCB0bXAp OwoKCS8qIEVuYWJsZSB0aGUgMTE0NCBmdW5jdGlvbnMgc2V0dGluZyAqLwoJaWYgKGhvc3QtPmlw X3ZlciA9PSBJUF9WRVJfTVQ2OTg5KSB7CgkJcmV0ID0gdWZzaGNkX2RtZV9nZXQoaGJhLCBVSUNf QVJHX01JQihWU19ERUJVR09NQyksICZ0bXApOwoJLi4uCn0KCkRvZXMgdGhpcyBjb2RlIHVuY29u ZGl0aW9uYWxseSBvdmVyd3JpdGUgdGhlIHJldHVybiB2YWx1ZSBvZiB1ZnNoY2RfZG1lX3NldCgp CndoZW4gdGhlIElQIHZlcnNpb24gbWF0Y2hlcyBNVDY5ODkgd2l0aG91dCBiZWluZyBjaGVja2Vk PwoKSWYgdWZzaGNkX2RtZV9zZXQoKSBmYWlscyB3aGlsZSBkaXNhYmxpbmcgZGVlcCBzdGFsbCwg dGhlIGZhaWx1cmUgYXBwZWFycyB0bwpiZSBzaWxlbnRseSBpZ25vcmVkIG9uIHRoZXNlIHBsYXRm b3Jtcy4KCkxlYXZpbmcgZGVlcCBzdGFsbCBpbmFwcHJvcHJpYXRlbHkgY29uZmlndXJlZCBtaWdo dCBsZWFkIHRvIFVGUyBidXMgbG9ja3VwcwphbmQgY29tbWFuZCB0aW1lb3V0cy4KCj4gIAljYXNl IFBPU1RfQ0hBTkdFOgo+ICAJCXVmc19tdGtfcG9zdF9saW5rKGhiYSk7Cj4gLQkJYnJlYWs7Cj4g LQlkZWZhdWx0Ogo+IC0JCXJldCA9IC1FSU5WQUw7Cj4gLQkJYnJlYWs7Cj4gKwkJcmV0dXJuIDA7 Cj4gIAl9Cj4gIAo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiAtRUlOVkFMOwo+ICB9CgpbIC4u LiBdCgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYWxzbyBhIHByZS1leGlzdGluZyBpc3N1ZSBp biB0aGlzIGZpbGUsIGJ1dCB3aGlsZSByZXZpZXdpbmcgdGhlIG5vdGlmeQpmdW5jdGlvbnMsIEkg bm90aWNlZCB0aGlzIGluIHVmc19tdGtfcHdyX2NoYW5nZV9ub3RpZnkoKToKCmRyaXZlcnMvdWZz L2hvc3QvdWZzLW1lZGlhdGVrLmM6dWZzX210a19wd3JfY2hhbmdlX25vdGlmeSgpIHsKCS4uLgoJ Y2FzZSBQUkVfQ0hBTkdFOgoJCWlmICh1ZnNoY2RfaXNfYXV0b19oaWJlcm44X3N1cHBvcnRlZCho YmEpKSB7CgkJCWhvc3QtPmFoaXQgPSB1ZnNoY2RfcmVhZGwoCgkJCQloYmEsIFJFR19BVVRPX0hJ QkVSTkFURV9JRExFX1RJTUVSKTsKCQkJdWZzX210a19hdXRvX2hpYmVybjhfZGlzYWJsZShoYmEp OwoJCX0KCQlyZXR1cm4gdWZzX210a19wcmVfcHdyX2NoYW5nZShoYmEsIGRldl9yZXFfcGFyYW1z KTsKCS4uLgp9CgpJcyB0aGUgcmV0dXJuIHZhbHVlIG9mIHVmc19tdGtfYXV0b19oaWJlcm44X2Rp c2FibGUoKSBpbnRlbnRpb25hbGx5IGlnbm9yZWQKaGVyZT8KCklmIGl0IGZhaWxzIGFuZCByZXR1 cm5zIGFuIGVycm9yIGxpa2UgLUVCVVNZLCB0aGUgY29kZSBwcm9jZWVkcyB0byBleGVjdXRlCnVm c19tdGtfcHJlX3B3cl9jaGFuZ2UoKS4KCkV4ZWN1dGluZyBwb3dlciBtb2RlIGNoYW5nZXMgd2hp bGUgdGhlIGxpbmsgaXMgc3R1Y2sgaW4gaGliZXJuOCBhbmQgZXJyb3IKcmVjb3ZlcnkgaXMgcGVu ZGluZyBjb3VsZCByZXN1bHQgaW4gaGFyZHdhcmUgbG9ja3VwcyBhbmQgdW5yZXNwb25zaXZlbmVz cyBpbgp0aGUgc3RvcmFnZSBzdWJzeXN0ZW0uCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0 cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwOTAxLW10ODE5Ni11ZnMtdjExLTAtZGJk MDA3NzA0NDkwQGNvbGxhYm9yYS5jb20/cGFydD0yMgoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxp c3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7EF547DFA8; Tue, 1 Sep 2026 16:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788280012; cv=none; b=RQ1Eqvw6yOEzG70Oz20Kq3D2AQDPMuQ1rMYZr5pksfZVqAoFOsCoY58dN9CpQfkjYVsvLqnj9WVdnp1/McMHdvj4WZJkUxirPpi4nIES1hCniKqzIqwqoaWc/KotLCeX9a1gUtw22eIKJ2R6scfwDq6pZfAyLIRsYoh+4myZhWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788280012; c=relaxed/simple; bh=VDPrcUUypC8KpVgHLZizy6lmKxS/ZLwHGx4uNkD4HsA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Bx7MLP0/Zwe9BcF07XykwfZ8KjGTDnTHRheYQJOhf2D4ht3NF6Dfn25C2RDFN1gXIeMIFDZCHosfn2KDAp3hzDgmcHGIAVuOc3xhyoFwvlLJtzPwLkhPtJupJ7iaBsqDahnx02JZmqblIoWaKOhMSwFEAX/bw70RwkxnpGZ9AGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SA7rYR8L; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SA7rYR8L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5B6D1F000E9; Tue, 1 Sep 2026 16:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788280010; bh=NVCcuS1Pbbtguh8VUMzbatetxCy9mJfpPGOgAUSyILU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SA7rYR8LHLfmH2XL38prYerkgTaI3USKMEzKCDKkQJ/XHEmTANnpxpxEYIzO0xTf3 LBNN4bnHGVA4Yq+K3BN+5WE1sTO6qaLLvZvuUJ646vLNUr15PwwNsj4qghbb/JhElI Z3FP3IZucbZhN62JzR/LAoJ+RZbxJVn4FBfvMONeB5XSI42K1H8l0YdcLScTmtedO4 /ex1ndktdXkxd1p7p9y3iwoSNR0E65nJC6ogd6NrgnQxm9+2a66aTOBTdI9kLpf4yP 6b39Tj0ijp18Cxb9jk8u8KozbDs9QAgf+02v87bu4BDi2FYnsQtA/1fvaIn7B1CqUY VyabUpqeuhpag== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 22/24] scsi: ufs: mediatek: Remove ret local from link_startup_notify Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260901-mt8196-ufs-v11-22-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> <20260901-mt8196-ufs-v11-22-dbd007704490@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 01 Sep 2026 16:26:49 +0000 Message-Id: <20260901162649.E5B6D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: Pre-existing issues: - [High] The return value of ufshcd_dme_set() is overwritten on MT6989 plat= forms without being checked, losing the error state. - [High] The return value of ufs_mtk_auto_hibern8_disable() is completely i= gnored in ufs_mtk_pwr_change_notify(). -- commit 8329ac726de58d3aa2453eb0ed319e7fbbfb2a6d Author: Nicolas Frattaroli scsi: ufs: mediatek: Remove ret local from link_startup_notify This commit removes the unused local ret variable from ufs_mtk_link_startup_notify. It also refactors the function to return directly from the switch statement. > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media= tek.c > index 4782fdf54866b..bcde58e3aee86 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -1543,21 +1543,15 @@ static void ufs_mtk_post_link(struct ufs_hba *hba) > static int ufs_mtk_link_startup_notify(struct ufs_hba *hba, > enum ufs_notify_change_status stage) > { > - int ret =3D 0; > - > switch (stage) { > case PRE_CHANGE: > - ret =3D ufs_mtk_pre_link(hba); > - break; > + return ufs_mtk_pre_link(hba); [Severity: High] This isn't a bug introduced by this patch, but looking at ufs_mtk_pre_link() which is called here: drivers/ufs/host/ufs-mediatek.c:ufs_mtk_pre_link() { ... ret =3D ufshcd_dme_set(hba, UIC_ARG_MIB(VS_SAVEPOWERCONTROL), tmp); /* Enable the 1144 functions setting */ if (host->ip_ver =3D=3D IP_VER_MT6989) { ret =3D ufshcd_dme_get(hba, UIC_ARG_MIB(VS_DEBUGOMC), &tmp); ... } Does this code unconditionally overwrite the return value of ufshcd_dme_set= () when the IP version matches MT6989 without being checked? If ufshcd_dme_set() fails while disabling deep stall, the failure appears to be silently ignored on these platforms. Leaving deep stall inappropriately configured might lead to UFS bus lockups and command timeouts. > case POST_CHANGE: > ufs_mtk_post_link(hba); > - break; > - default: > - ret =3D -EINVAL; > - break; > + return 0; > } > =20 > - return ret; > + return -EINVAL; > } [ ... ] [Severity: High] This is also a pre-existing issue in this file, but while reviewing the not= ify functions, I noticed this in ufs_mtk_pwr_change_notify(): drivers/ufs/host/ufs-mediatek.c:ufs_mtk_pwr_change_notify() { ... case PRE_CHANGE: if (ufshcd_is_auto_hibern8_supported(hba)) { host->ahit =3D ufshcd_readl( hba, REG_AUTO_HIBERNATE_IDLE_TIMER); ufs_mtk_auto_hibern8_disable(hba); } return ufs_mtk_pre_pwr_change(hba, dev_req_params); ... } Is the return value of ufs_mtk_auto_hibern8_disable() intentionally ignored here? If it fails and returns an error like -EBUSY, the code proceeds to execute ufs_mtk_pre_pwr_change(). Executing power mode changes while the link is stuck in hibern8 and error recovery is pending could result in hardware lockups and unresponsiveness in the storage subsystem. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260901-mt8196-ufs= -v11-0-dbd007704490@collabora.com?part=3D22