From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AF77C624D3 for ; Tue, 1 Sep 2026 16:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jafSx5RwaNGGH3X0LYYEGR31eCQuoc5Q6upzFNewoD8=; b=BchvITU9/sYwDf 3UOxEd3qtaToEcKlf+oVknGRgF1cw15Hj8w9LNV0t6OjqBMx7B1yCQ+m5ppqYCEPg0F2XmtQ9bl+h Me1wIqmQn7HX81GqyGHfYaOlz4jMReKDZntgm5clmCqKc5RNMw0L8l6oMjxDub3MuH+L66huYXwPl fDlvnTsIktZ7eWFgcxye1/CH/2AIEyLk7q4vGlg6CQk4Pu4kQ7IbiJ8w6RXcNN22+YypnXOKrvMHs 3vnXhO36OMO0iJ3YHMpuiEcclpVIm+AoNiVZNwr+HXKIAf7dXo0uO8tlrshptXMsJpsXgvwvMNSB3 Ix+ZlX7+R1dSKdk93dZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1RPR-0000000CfJu-2vBG; Tue, 01 Sep 2026 16:32:29 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1RPR-0000000CfJj-0poW for linux-phy@lists.infradead.org; Tue, 01 Sep 2026 16:32:29 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D83A840A95; Tue, 1 Sep 2026 16:32:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C1E81F000E9; Tue, 1 Sep 2026 16:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788280348; bh=RVThgaMR7YohtKU+H34GcPG6L+uQ/2tYAFBh5huo7Aw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NEcYq2JYd/dvywBUlY5TZauCY6BC/h3ZQk+q0O8o2ofgu8WAguvE2utBzaLhf2WTZ CBoNatInlvzyrgUR1nZ3dna6okUWkCPJgzGTWXB9S650GbL7efzj//P2LIlI5v4OVe hfIByv2BfvOfQ3C50rzJflWiqXwLOk6YNzgVX6AXy9a+t+aQZ1vef54u4FSrI8CYAR PC4U+VnaEJsc5RwYUGkI8kWwA2PqUOTGG81gei3XnwOV2U+pE+AL+MeIgooLdGPbpH nmSi6Brc+wmPiEOr1q0OftMn6ameRzg6CsQBZTqxm6YYlCG8yn1Nk+BA73GdgUfSFg 2knVwUg1N99Ig== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 24/24] scsi: ufs: mediatek: Add MT8196 compatible, update copyright To: "Louis-Alexis Eyraud" Cc: olteanv@gmail.com, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, conor+dt@kernel.org In-Reply-To: <20260901-mt8196-ufs-v11-24-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> <20260901-mt8196-ufs-v11-24-dbd007704490@collabora.com> Date: Tue, 01 Sep 2026 16:32:27 +0000 Message-Id: <20260901163228.3C1E81F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBJbmNvbnNpc3RlbnQgaGFyZHdhcmUgc3RhdGUgb24gcm9sbGJhY2sgZmFpbHVyZSBp biB1ZnNfbXRrXzA5dl9vZmYoKSBsZWFkcyB0byByZWd1bGF0b3Igc3RhdGUgbWlzbWF0Y2ggYW5k IHBvdGVudGlhbCBjcmFzaC4KLS0KCmNvbW1pdCA1MzI1OTJkMTg2MmQ5NDJkZDA5NDAwZDY4ODgw MzExMWZjMmQxMmNiCkF1dGhvcjogTmljb2xhcyBGcmF0dGFyb2xpIDxuaWNvbGFzLmZyYXR0YXJv bGlAY29sbGFib3JhLmNvbT4KCnNjc2k6IHVmczogbWVkaWF0ZWs6IEFkZCBNVDgxOTYgY29tcGF0 aWJsZSwgdXBkYXRlIGNvcHlyaWdodAogICAgClRIZSBNVDgxOTYncyBVRlMgY29udHJvbGxlciBo YXMgYSBuZXcgY29tcGF0aWJsZS4gQWRkIHRoZSBuZWNlc3NhcnkKc3RydWN0IGRlZmluaXRpb25z IHRvIHN1cHBvcnQgaXQuCiAgICAKQWxzbyB1cGRhdGUgdGhlIGNvcHlyaWdodHMgYW5kIGF1dGhv cnMsIHdpdGhvdXQgdGFicyBmb2xsb3dpbmcgc3BhY2VzIHRvCmF2b2lkIGNoZWNrcGF0Y2ggZXJy b3JzLCB0byBsaXN0IG15c2VsZiBhcyBoYXZpbmcgY29udHJpYnV0ZWQgdG8gdGhpcwpkcml2ZXIg YWZ0ZXIgdGhlIHByZWNlZGluZyByZXdvcmsgcGF0Y2hlcy4KCj4gVEhlIE1UODE5NidzIFVGUyBj b250cm9sbGVyIGhhcyBhIG5ldyBjb21wYXRpYmxlLiBBZGQgdGhlIG5lY2Vzc2FyeQoKVGhpcyBp c24ndCBhIGJ1ZywgYnV0IHRoZXJlIGlzIGEgdHlwbyAoVEhlKSBpbiB0aGUgY29tbWl0IG1lc3Nh Z2UuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jIGIvZHJp dmVycy91ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYwo+IGluZGV4IGE4OTQ4MTBhODNkZTcuLmU2YTY3 Mjg4OGQwNDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYwo+ ICsrKyBiL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmMKClsgLi4uIF0KCj4gQEAgLTIy NTQsMTAgKzIyNjAsMTggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB1ZnNfbXRrX3NvY19kYXRhIG10 ODE5Ml84MTk1X2RhdGEgPSB7Cj4gIAkubnVtX3JlZ19uYW1lcyA9IEFSUkFZX1NJWkUodWZzX210 a19yZWdzX2F2ZGQxMl9ja2J1Zl9hdmRkMTgpLAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHN0 cnVjdCB1ZnNfbXRrX3NvY19kYXRhIG10ODE5Nl9kYXRhID0gewo+ICsJLmhhc19hdmRkMDkgPSB0 cnVlLAo+ICsJLmhhc19hdmRkMDlfMSA9IHRydWUsCgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMg YSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCB0aGlzIGNvbW1pdCBleHBsaWNpdGx5IGV4cG9zZXMg YSBkb3JtYW50CnJlZ3VsYXRvciBzdGF0ZSBtaXNtYXRjaCBidWcgYmVjYXVzZSBtdDgxOTZfZGF0 YSBpcyB0aGUgZmlyc3QgdG8gc2V0Cmhhc19hdmRkMDlfMSB0byB0cnVlLgoKSW4gdWZzX210a18w OXZfb2ZmKCksIGlmIGhvc3QtPnJlZ19hdmRkMDkgaXMgc3VjY2Vzc2Z1bGx5IGRpc2FibGVkIGJ1 dApob3N0LT5yZWdfYXZkZDA5XzEgc3Vic2VxdWVudGx5IGZhaWxzIHRvIGRpc2FibGUsIHRoZSBm dW5jdGlvbiBlbnRlcnMgYW4KZXJyb3Igcm9sbGJhY2sgcGF0aDoKCmRyaXZlcnMvdWZzL2hvc3Qv dWZzLW1lZGlhdGVrLmM6dWZzX210a18wOXZfb2ZmKCkgewouLi4KCWlmIChob3N0LT5yZWdfYXZk ZDA5KSB7CgkJcmV0ID0gcmVndWxhdG9yX2Rpc2FibGUoaG9zdC0+cmVnX2F2ZGQwOSk7Ci4uLgoJ fQoKCWlmIChob3N0LT5yZWdfYXZkZDA5XzEpIHsKCQlyZXQgPSByZWd1bGF0b3JfZGlzYWJsZSho b3N0LT5yZWdfYXZkZDA5XzEpOwoJCWlmIChyZXQpIHsKCQkJZGV2X2Vycihob3N0LT5oYmEtPmRl diwgIkZhaWxlZCB0byBkaXNhYmxlIGF2ZGQwOS0xLXN1cHBseTogJXBlXG4iLAoJCQkJRVJSX1BU UihyZXQpKTsKCQkJdWZzX210a192YTA5X3B3cl9jdHJsKHJlcywgMSk7CgkJCXJldHVybiByZXQ7 CgkJfQoJfQouLi4KfQoKSXQgcmVzdG9yZXMgU01DIHBvd2VyIHdpdGggdWZzX210a192YTA5X3B3 cl9jdHJsKHJlcywgMSkgYW5kIHJldHVybnMgYW4KZXJyb3IsIGJ1dCBjcnVjaWFsbHkgbWlzc2Vz IGNhbGxpbmcgcmVndWxhdG9yX2VuYWJsZShob3N0LT5yZWdfYXZkZDA5KSB0bwpyZXZlcnQgdGhl IHByZXZpb3VzbHkgZGlzYWJsZWQgaG9zdC0+cmVnX2F2ZGQwOSByZWd1bGF0b3IuCgpUaGlzIGxl YXZlcyB0aGUgVUZTIFBIWSBzdGF0ZSBtYXJrZWQgYXMgcG93ZXJlZCBvbiwgYnV0IHRoZSBQSFkg aXMKcGh5c2ljYWxseSBkaXNhYmxlZCBhbmQgaXRzIGVzc2VudGlhbCByZWdfYXZkZDA5IHJlZ3Vs YXRvciBpcyBwb3dlcmVkIG9mZi4KCkNvdWxkIHN1YnNlcXVlbnQgYWNjZXNzZXMgdG8gdGhlIFVG UyBjb250cm9sbGVyIGF0dGVtcHQgdG8gb3BlcmF0ZSBvbgp1bnBvd2VyZWQgaGFyZHdhcmUsIGxp a2VseSBjYXVzaW5nIGEgaGFyZHdhcmUgaGFuZyBvciBhbiBhc3luY2hyb25vdXMKZXh0ZXJuYWwg YWJvcnQgdGhhdCBjcmFzaGVzIHRoZSBzeXN0ZW0/Cgo+ICsJLnJlZ19uYW1lcyA9IHVmc19tdGtf cmVnc19hdmRkMTJfY2tidWYsCj4gKwkubnVtX3JlZ19uYW1lcyA9IEFSUkFZX1NJWkUodWZzX210 a19yZWdzX2F2ZGQxMl9ja2J1ZiksCj4gK307Cj4gKwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3 IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDkwMS1tdDgxOTYtdWZzLXYxMS0w LWRiZDAwNzcwNDQ5MEBjb2xsYWJvcmEuY29tP3BhcnQ9MjQKCi0tIApsaW51eC1waHkgbWFpbGlu ZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EDBA47ECC1; Tue, 1 Sep 2026 16:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788280350; cv=none; b=GtKmHaMcf6pcjQjW/h5Lv9IZwoJCa2cH5SxiVTYwqYETZ83DArx6fgbpfrHdugohngGbfSgRBLY+axjAo7xsO2DgmyMJJi8gFmFagQs4UcrbqFHzQAzOIV+riMKscv55+7m9lbXtJnZJasGy3rfsCK2zNVAmA8JHfogWtYYtB+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788280350; c=relaxed/simple; bh=/zkxMpUggAMf1m7EghNt+ZY9m+DyQrjrU6E72Mj9ZfU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NiGpQvJvfYsnA5+lJtqxlzUfndwZt6djN3aASMnaZPL3oagoND+4vZaV2KBtTu5zt1UZQcJ5su4yJEPKRLmr5rVxr4vutD+WISCS2x+JBGLwdM9igpr8FL8rRw2cO6lSs8PJ/ERN4IqrRslTZKrBMTBSfSwpZdJ72eqz4IEn6jM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NEcYq2JY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NEcYq2JY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C1E81F000E9; Tue, 1 Sep 2026 16:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788280348; bh=RVThgaMR7YohtKU+H34GcPG6L+uQ/2tYAFBh5huo7Aw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NEcYq2JYd/dvywBUlY5TZauCY6BC/h3ZQk+q0O8o2ofgu8WAguvE2utBzaLhf2WTZ CBoNatInlvzyrgUR1nZ3dna6okUWkCPJgzGTWXB9S650GbL7efzj//P2LIlI5v4OVe hfIByv2BfvOfQ3C50rzJflWiqXwLOk6YNzgVX6AXy9a+t+aQZ1vef54u4FSrI8CYAR PC4U+VnaEJsc5RwYUGkI8kWwA2PqUOTGG81gei3XnwOV2U+pE+AL+MeIgooLdGPbpH nmSi6Brc+wmPiEOr1q0OftMn6ameRzg6CsQBZTqxm6YYlCG8yn1Nk+BA73GdgUfSFg 2knVwUg1N99Ig== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 24/24] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: olteanv@gmail.com, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, conor+dt@kernel.org In-Reply-To: <20260901-mt8196-ufs-v11-24-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> <20260901-mt8196-ufs-v11-24-dbd007704490@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 01 Sep 2026 16:32:27 +0000 Message-Id: <20260901163228.3C1E81F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Inconsistent hardware state on rollback failure in ufs_mtk_09v_off= () leads to regulator state mismatch and potential crash. -- commit 532592d1862d942dd09400d688803111fc2d12cb Author: Nicolas Frattaroli scsi: ufs: mediatek: Add MT8196 compatible, update copyright =20 THe MT8196's UFS controller has a new compatible. Add the necessary struct definitions to support it. =20 Also update the copyrights and authors, without tabs following spaces to avoid checkpatch errors, to list myself as having contributed to this driver after the preceding rework patches. > THe MT8196's UFS controller has a new compatible. Add the necessary This isn't a bug, but there is a typo (THe) in the commit message. > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media= tek.c > index a894810a83de7..e6a672888d043 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c [ ... ] > @@ -2254,10 +2260,18 @@ static const struct ufs_mtk_soc_data mt8192_8195_= data =3D { > .num_reg_names =3D ARRAY_SIZE(ufs_mtk_regs_avdd12_ckbuf_avdd18), > }; > =20 > +static const struct ufs_mtk_soc_data mt8196_data =3D { > + .has_avdd09 =3D true, > + .has_avdd09_1 =3D true, [Severity: High] This is a pre-existing issue, but this commit explicitly exposes a dormant regulator state mismatch bug because mt8196_data is the first to set has_avdd09_1 to true. In ufs_mtk_09v_off(), if host->reg_avdd09 is successfully disabled but host->reg_avdd09_1 subsequently fails to disable, the function enters an error rollback path: drivers/ufs/host/ufs-mediatek.c:ufs_mtk_09v_off() { ... if (host->reg_avdd09) { ret =3D regulator_disable(host->reg_avdd09); ... } if (host->reg_avdd09_1) { ret =3D regulator_disable(host->reg_avdd09_1); if (ret) { dev_err(host->hba->dev, "Failed to disable avdd09-1-supply: %pe\n", ERR_PTR(ret)); ufs_mtk_va09_pwr_ctrl(res, 1); return ret; } } ... } It restores SMC power with ufs_mtk_va09_pwr_ctrl(res, 1) and returns an error, but crucially misses calling regulator_enable(host->reg_avdd09) to revert the previously disabled host->reg_avdd09 regulator. This leaves the UFS PHY state marked as powered on, but the PHY is physically disabled and its essential reg_avdd09 regulator is powered off. Could subsequent accesses to the UFS controller attempt to operate on unpowered hardware, likely causing a hardware hang or an asynchronous external abort that crashes the system? > + .reg_names =3D ufs_mtk_regs_avdd12_ckbuf, > + .num_reg_names =3D ARRAY_SIZE(ufs_mtk_regs_avdd12_ckbuf), > +}; > + --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260901-mt8196-ufs= -v11-0-dbd007704490@collabora.com?part=3D24