From: Stefan Hajnoczi <stefanha@redhat.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Sam Li <faithilikerun@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH v2] file-posix: fix zone write granularity assignment for zoned block devices
Date: Tue, 1 Sep 2026 14:38:28 -0400 [thread overview]
Message-ID: <20260901183828.GB616149@fedora> (raw)
In-Reply-To: <aoXkRgCp-EArgj26@ryzen>
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
On Wed, Aug 19, 2026 at 07:13:42PM +0200, Niklas Cassel wrote:
> On Tue, Aug 11, 2026 at 03:32:36PM +0200, Niklas Cassel wrote:
> > In the ZBC and ZAC specifications, the requirement is that the write
> > granularity matches the physical block size.
> >
> > However, in the ZNS specification, the requirement is simply that the
> > write granularity matches the logical block size.
> >
> > See:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a805a4fa4fa376bbc145762bb8b09caa2fa8af48
> >
> > In Linux, there is a zone_write_granularity sysfs property which abstracts
> > this away, so let's make use of it.
> >
> > Currently, it is theoretically possible that QEMU presents an inflated
> > write granularity for NVMe devices where the physical block size is larger
> > than the logical block size.
> >
> > Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> > Fixes: a3c41f06d5a8 ("file-posix: add tracking of the zone write pointers")
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
>
> Stefan,
>
> Since you already have another zoned storage fix for file-posix.c queued:
> https://gitlab.com/stefanha/qemu/-/commits/block-next
>
> Could you perhaps queue this one as well?
Yes. Kevin is away for a few days and this is a small patch, so I will
merge it.
Applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-09-01 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 13:32 [PATCH v2] file-posix: fix zone write granularity assignment for zoned block devices Niklas Cassel
2026-08-12 15:03 ` Stefan Hajnoczi
2026-08-19 17:13 ` Niklas Cassel
2026-09-01 18:38 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901183828.GB616149@fedora \
--to=stefanha@redhat.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=faithilikerun@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.