Re: [PATCH v2 09/13] regulator: ab8500: Add buck converter support

[sashiko-bot@kernel.org]

> Register the SMPS1, SMPS2, SMPS3, ARM, APE and MOD buck converters on
> AB8500 and the VSMPSA, VSMPSB, VSAFE, VARM, VSMPSC and VSMPSM buck
> converters on AB8505 so that the new device tree nodes can supply
> consumers. Match each variant through its own device tree node names.
> 
> AB8500 SMPS3 supplies Vsafe and AB8505 VSAFE occupies the corresponding
> control and selector registers at 0x0405 and 0x041b through 0x041d.
> AB8500 VAPE and AB8505 VSMPSC instead use 0x0402 and the 0x040e through
> 0x0410 selector registers. Keep separate AB8505 regulator descriptors
> and identifiers so these variant-specific rails are not conflated.
> 
> Describe the hardware selector ranges and follow the selector-control
> registers when reading or changing voltage. This accounts for AB8505
> using Sel2 after reset, its additional selector registers and its
> separate 7-bit VARM range. Use the AB8500-compatible and low-range OTP
> profiles found on the supported platforms for the other rails.
> 
> SMPS1 through SMPS3 and VSMPSA, VSMPSB and VSAFE also expose enable and
> low-power mode control. Keep the ARM, APE, MOD, VARM, VSMPSC and VSMPSM
> rails voltage-only since their on/off state is managed with the SoC.
> 
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-ux500-dts-snowball-regulator-v2-0-fe88b01829bf@kernel.org?part=9