From: Greg KH <gregkh@linuxfoundation.org>
To: Arihan Bhor <dogestad24@gmail.com>
Cc: ovidiu.panait.oss@gmail.com, gustavopiazdasilva210@gmail.com,
error27@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/axis-fifo: fix formatting issue
Date: Tue, 1 Sep 2026 12:11:56 +0200 [thread overview]
Message-ID: <2026090145-curing-generous-374d@gregkh> (raw)
In-Reply-To: <20260822064627.79029-1-dogestad24@gmail.com>
On Sat, Aug 22, 2026 at 12:16:27PM +0530, Arihan Bhor wrote:
> The issue as reported by checkpatch -
>
> CHECK: Alignment should match open parenthesis
>
> #249: FILE: drivers/staging/axis-fifo/axis-fifo.c:249:
> + ret = wait_event_interruptible(fifo->write_queue,
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
>
> Signed-off-by: Arihan Bhor <dogestad24@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870ea9..13a4f329a2e3 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> mutex_lock(&fifo->write_lock);
>
> ret = wait_event_interruptible(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> + ioread32(fifo->base_addr +
> + XLLF_TDFV_OFFSET) >= words_to_write);
> if (ret)
> goto end_unlock;
> }
>
> base-commit: 26260251022fbc2f248a3d747a9b2b961b18d2d8
> --
> 2.55.0
>
>
Does not apply to the staging-testing branch. Can you please rebase and
resend?
thanks,
greg k-h
prev parent reply other threads:[~2026-09-01 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 6:46 [PATCH] drivers/staging/axis-fifo: fix formatting issue Arihan Bhor
2026-09-01 10:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090145-curing-generous-374d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dogestad24@gmail.com \
--cc=error27@gmail.com \
--cc=gustavopiazdasilva210@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.